Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub ci jsonschema/v13 #797

Closed
wants to merge 7 commits into from

Conversation

catenacyber
Copy link
Collaborator

Part of #789 with other commit in #796

@catenacyber catenacyber added the framework Has a suricata-verify framework change label Apr 8, 2022
@catenacyber catenacyber force-pushed the github-ci-jsonschema/v13 branch from 274543a to 460aeec Compare April 8, 2022 15:26
@catenacyber
Copy link
Collaborator Author

Still need to add some recent changes...

@catenacyber catenacyber force-pushed the github-ci-jsonschema/v13 branch from 460aeec to a2d3b98 Compare April 11, 2022 20:27
@catenacyber
Copy link
Collaborator Author

Still need to add some recent changes...

Should be done now

@catenacyber catenacyber added the tests pass These new tests should pass label Apr 11, 2022
@catenacyber catenacyber requested a review from jasonish April 14, 2022 14:44
@catenacyber
Copy link
Collaborator Author

@catenacyber
Copy link
Collaborator Author

@jasonish what do you think of this ?

@jasonish
Copy link
Member

@jasonish what do you think of this ?

I like it. But I think the schema needs to move to Suricata source tree. Otherwise how do we handle the multiple Suricata branches?

@catenacyber
Copy link
Collaborator Author

Done in #826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Has a suricata-verify framework change tests pass These new tests should pass
Development

Successfully merging this pull request may close these issues.

2 participants