Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/20220329/v2 #7186

Merged
merged 13 commits into from
Mar 30, 2022
Merged

Next/20220329/v2 #7186

merged 13 commits into from
Mar 30, 2022

Conversation

catenacyber and others added 13 commits March 29, 2022 07:56
With this check, on the first packet of a certificate presenting
a length of 16Mbytes, we only allocate up to 65Kb

When we get to the point where need more than 65Kb, we realloc
to the true size.

With this check, it makes it more expensive for an attacket to use
this allocation as a way to trigger ressource exhaustion...
Ticket: 4860

instead of root field
The documentation was showing an invalid path for running single tests.
Moved devguide dir into userguide dir.
Since the devguide is now incorporated as the last chapter of the
userguide, removed build and configuration files from the devguide
dir, as these are no longer needed.

Task OISF#4909
Make it more evident that the sequence diagrams in the transactions
page are generated with Mscgen
Currently, it seems easier to upload the diagram images to git than to
try to make the image generation script work with out of the tree builds
and other corner cases.

This means, however, that one must activelly remember to update msc
diagram files, run the script and re-add new png files, if those ever
need to be updated. To raise awareness to that, a watermark was added
to the diagram images.

Also removed configuration steps that added mscgen as dependency
(locally and for workflow builds and readthedocs).
This uses the date of doc generation to determine the copyright date
for the trailing date. Based on Jeff Lucovsky solution.
Use it to explain how to go about the sequence diagram images
(generation, updating, what is mscgen etc).

Also remove portion that referred to Sphinx builds, as these don't make
sense now.
Meant to find more cases where there is a mismatch.
Instead of closing files in both direction when receiving a close request,
close only toserver files for the request and close toclient on receiving
a response.
Increment files_opened for tx that 'gets' reassembled ranged file
@victorjulien victorjulien requested review from jasonish, norg and a team as code owners March 29, 2022 12:59
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #7186 (9537d11) into master (99b3443) will decrease coverage by 0.04%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master    #7186      +/-   ##
==========================================
- Coverage   78.13%   78.09%   -0.05%     
==========================================
  Files         628      628              
  Lines      184541   184549       +8     
==========================================
- Hits       144199   144128      -71     
- Misses      40342    40421      +79     
Flag Coverage Δ
fuzzcorpus 60.36% <82.14%> (-0.16%) ⬇️
suricata-verify 54.60% <77.77%> (-0.03%) ⬇️
unittests 62.95% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 6683

@victorjulien victorjulien merged commit 9537d11 into OISF:master Mar 30, 2022
@victorjulien victorjulien deleted the next/20220329/v2 branch April 14, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants