Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/393/20240413/v1 #10832

Merged
merged 12 commits into from
Apr 14, 2024
Merged

Conversation

Lukas Sismis and others added 12 commits April 13, 2024 08:50
Some stats can be quite verbose if logging all zero valued-counters.
This allows users to disable logging such counters. Default is still
true, as that's the expected behavior for the engine.

Task OISF#5976
Eve's packet_info.linktype should correctly indicated what the `packet`
field contains. Until now it was using DLT_RAW even if Ethernet or other
L2+ headers were present.

This commit records the datalink of the packet creating the first
fragment, which can include the L2+ header data.

Bug: OISF#6887.
This is just another variant of DLT_RAW.

Ticket: OISF#6943.
This commit moves the memcap pressure/pressure_max stats from the global
stats namespace into the memcap namespace.

With per-thread stats, they will be within the flow-manager's values.

Issue: 6398
+ remove double definition of IPPairLock

Ticket: OISF#4083
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.83%. Comparing base (365a66a) to head (784ce30).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10832      +/-   ##
==========================================
+ Coverage   82.67%   82.83%   +0.16%     
==========================================
  Files         928      913      -15     
  Lines      247912   246847    -1065     
==========================================
- Hits       204952   204474     -478     
+ Misses      42960    42373     -587     
Flag Coverage Δ
fuzzcorpus 64.30% <80.00%> (+0.29%) ⬆️
suricata-verify 62.09% <95.83%> (+0.08%) ⬆️
unittests 62.33% <60.83%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 138 144 104.35%

Pipeline 20046

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20052

Copy link
Contributor

@lukashino lukashino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -1,4 +1,4 @@
/* Copyright (C) 2014 Open Information Security Foundation
/* Copyright (C) 2014-2024 Open Information Security Foundation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the copyright somewhat automatically for every file every year?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants