Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk: fix compatibility issues for ice cards v1 #10729

Closed
wants to merge 2 commits into from

Conversation

lukashino
Copy link
Contributor

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6871

Describe changes:

  • increased the key length from 40 to 52 bytes - the default length is still 40 but the key is 52 bytes long to comply with the ice requirements
  • changed the RSS API for the ICE cards - setting also the key length and not just the RSS hash functions

@lukashino lukashino requested a review from victorjulien as a code owner March 27, 2024 08:34
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.74%. Comparing base (ee50fe4) to head (ca4f344).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10729      +/-   ##
==========================================
+ Coverage   78.52%   82.74%   +4.21%     
==========================================
  Files         926      926              
  Lines      247464   247654     +190     
==========================================
+ Hits       194331   204914   +10583     
+ Misses      53133    42740   -10393     
Flag Coverage Δ
fuzzcorpus 64.15% <ø> (-0.08%) ⬇️
suricata-verify 62.00% <ø> (?)
unittests 62.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 138 143 103.62%

Pipeline 19844

@victorjulien victorjulien added this to the 8.0 milestone Apr 13, 2024
@victorjulien
Copy link
Member

Merged in #10832, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants