eve/stats: allow hiding counters whose valued is 0 - v3 #10809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some stats can be quite verbose if logging all zero valued-counters. This allows users to disable logging such counters. Default is still true, as that's the expected behavior for the engine. Task OISF#5976
This was referenced Apr 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10809 +/- ##
=======================================
Coverage 82.75% 82.76%
=======================================
Files 928 928
Lines 247913 247921 +8
=======================================
+ Hits 205162 205181 +19
+ Misses 42751 42740 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 20018 |
victorjulien
approved these changes
Apr 12, 2024
Merged
|
Merged in #10832, thanks! |
|
Thanks for this feature Juliana :-) |
🙇🏽 ! I feel it will only be complete when this can be done for individual counters, though :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stats can be quite verbose if logging all zero valued-counters. This allows users to disable logging such counters. Default is still true, as that's the expected behavior for the engine.
Task #5976
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5976
Previous PR: #10766
Describe changes:
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#1753
Json Stats Output Sample
jq .stats -c eve.json (from the
feature-5976-zero-stats-01sv test){"uptime":0,"ips":{"accepted":32},"decoder":{"pkts":32,"bytes":9598,"ipv6":32,"ethernet":32,"tcp":32,"avg_pkt_size":299,"max_pkt_size":2974},"tcp":{"syn":1,"synack":1,"rst":3,"sessions":1,"ssn_from_pool":1,"segment_from_cache":9,"segment_from_pool":7,"memuse":7667712,"reassembly_memuse":1376256},"flow":{"total":1,"tcp":1,"wrk":{"spare_sync_avg":100,"spare_sync":1},"end":{"state":{"closed":1},"tcp_state":{"closed":1}},"mgr":{"rows_per_sec":13762},"spare":9900,"recycler":{"recycled":1,"queue_max":1},"memuse":7154304},"app_layer":{"flow":{"tls":1}},"memcap_pressure":21,"memcap_pressure_max":21}