haskellPackages: Add buildFromCabalSdist (faster, tested)

[roberth]

Description of changes

A faster buildFromSdist, with tests. For use in out-of-tree projects. Triggered by #173800 (comment)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[roberth]

@ofborg build tests.haskell.cabalSdist

[maralorn]

How common do we think would people encounter breakage if we just changed the existing buildFromSdist?
I am a bit careful with adding more functions with subtle differences to our lib.

Do you have a reason for adding those functions in another file then the original one?

[roberth]

Do you have a reason for adding those functions in another file then the original one?

It needs to access the package set for buildHaskellPackages.cabal-install, which is not something we can access in haskell.lib, unless there's some trickery I'm not aware of.

How common do we think would people encounter breakage if we just changed the existing buildFromSdist?

It seems that cabal sdist does not support custom ./Setup sdist behavior, so hypothetically, a package could have its own custom / customized sdist logic that the new function won't invoke. This seems unlikely though, as cabal-install command users would already be unable to use such custom logic.

[maralorn]

1. I think the implementation is very good, thanks for the test!
2. I realized that my fear of making our library more confusing is 100% a documentation problem and giving the users different options for (even mildly) different usecases is exactly right.

I am okay with merging this. Any objections @NixOS/haskell ?

[github-actions]

Successfully created backport PR #179427 for release-22.05.