Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdistTarball requires all dependencies to be built, but this is not necessary #45020

Closed
ocharles opened this issue Aug 14, 2018 · 3 comments
Closed

Comments

@ocharles
Copy link
Contributor

ocharles commented Aug 14, 2018

Issue description

pkgs.haskell.lib.sdistTarball overrides a package's derivation to have a build phase that simply calls ./Setup sdist. However, all build inputs are retained, but these are not necessary. The current behavior means that sdistTarball cannot complete until all dependencies are built, but if you only need the tarball this delays the build.

I believe we can just add the following:

 configurePhase = ":";
 buildInputs = [];
 propagatedBuildInputs = [];

to sdistTarball.

@stale
Copy link

stale bot commented Jun 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2020
@sternenseemann
Copy link
Member

sternenseemann commented Jan 22, 2023

I would recommend using haskell.packages.*.cabalSdist added in #174176 for this purpose which avoids both building dependencies and even compiling Setup.hs.

(I'm not sure if emptying configurePhase would be okay, but avoiding deps compilation could still be possible in sdistTarball)

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 22, 2023
@ocharles
Copy link
Contributor Author

I don't have any need for this anymore so I'm going to close this issue. It sounds like there is a good solution/workaround now, too!

@ocharles ocharles closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants