tests.haskell.cabalSdist.localFromCabalSdist: prevent unnecessary rebuilds #321246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2024
|
@ofborg build tests.haskell.cabalSdist |
…sary rebuilds" This reverts commit 81c06bc. Reason for revert: This change breaks the `tests.haskell.cabalSdist.assumptionLocalHasDirectReference` test which relies on checking for the test source store path in the resulting derivation files. 81c06bc did not account for this in the change (though it should be possible).
sternenseemann
force-pushed
the
revert-cabal-sdist-file-set
branch
from
e5b22e5 to
d77ed98
Compare
sternenseemann
changed the title
|
@ofborg build tests.haskell.cabalSdist |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Yes, I reverted the wrong commit initially, that has been fixed. |
|
@philiptaron I think it should be fixable if a fileset expression is used instead of |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.