Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-21.05] linkerd: 2020-05-01 -> edge-21.6.2 #127154

Merged
merged 3 commits into from
Jun 20, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Description

Backport of #127130 to release-21.05.

linkerd.stable: init stable-2.9.5
linkerd.edge: init edge-21.6.2

Fixes #113218

This PR was a huge colaboration between many people: @NobbZ, @kalbasit, @tomberek, @ldesgoui, @Gonzih, @jnetod, @bryanasdev000, @AndersonTorres and more...
And @jnetod won the crown by being the last one to put the nail in the coffin!

Co-authored-by: bryanasdev000 <[email protected]>
Co-authored-by: jnetod <[email protected]>
Co-authored-by: AndersonTorres <[email protected]>
(cherry picked from commit 24b04ac)
@bryanasdev000
Copy link
Member

Hmm looks like tests failed...

@jnetod
Copy link
Contributor

jnetod commented Jun 17, 2021

It depends on #125520 backport.

@bryanasdev000
Copy link
Member

Which in turn may bring #125597.

What a fun ride :P

@superherointj
Copy link
Contributor

superherointj commented Jun 17, 2021

Edit: jneto found a solution that doesn't require ldflags.
It can be backported.

@bryanasdev000
Copy link
Member

We are closing this, if in the future @NixOS/golang merge this two PRs we can consider reopening it, but its too much trouble for a single package specially handling such mass rebuild :P

@AndersonTorres AndersonTorres merged commit 60e4d51 into release-21.05 Jun 20, 2021
@Artturin Artturin deleted the backport-127130-to-release-21.05 branch November 22, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants