go_1_15: 1.15.12 -> 1.15.13, go_1_16: 1.16.4 -> 1.16.5 #125597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarch64-darwin is only supported on >= 1.16
ofborg
bot
requested review from
rvolosatovs,
mdlayher,
Mic92,
kalbasit,
cstrahan,
Frostman and
c00w
ofborg
bot
added
11.by: package-maintainer
zowoq
commented
Jun 4, 2021
| @@ -29,6 +29,7 @@ stdenv.mkDerivation rec { | |||
| dontStrip = stdenv.hostPlatform.isDarwin; | |||
|
|
|||
| installPhase = '' | |||
| runHook preInstall | |||
There was a problem hiding this comment.
nixpkgs-hammering will probably flag this a some point, adding them in this PR as they cause a full go_* rebuild.
I'll a no-op cleanup and nixpkgs-fmt of go in a follow up PR after this is merged.
bobrik
approved these changes
Jun 4, 2021
9 tasks
|
Can it be backported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)Might try to land this at the same time as the
ldflagsPR to save on rebuilds.