Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkerd: 2020-05-01 -> edge-21.6.2 #127130

Merged
merged 1 commit into from
Jun 17, 2021
Merged

linkerd: 2020-05-01 -> edge-21.6.2 #127130

merged 1 commit into from
Jun 17, 2021

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Jun 16, 2021 •
edited
Loading

linkerd.stable: init stable-2.9.5
linkerd.edge: init edge-21.6.2

Fixes #113218

This PR was a huge colaboration between many people: @NobbZ, @kalbasit, @tomberek, @ldesgoui, @Gonzih, @jnetod, @bryanasdev000, @AndersonTorres and more...

And @jnetod won the crown by being the last one to put the hardest nail in the coffin!

@superherointj superherointj marked this pull request as draft June 16, 2021 20:17
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 16, 2021
@ofborg ofborg bot requested review from bryanasdev000, kalbasit and Gonzih June 16, 2021 20:22
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 16, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/package-linkerd-go/13651/18

@superherointj superherointj marked this pull request as ready for review June 16, 2021 20:28
@superherointj superherointj marked this pull request as draft June 16, 2021 21:11
@AndersonTorres
Copy link
Member

AndersonTorres commented Jun 16, 2021 •
edited
Loading

Thou shall never start version attributes with non-numerical characters

@superherointj superherointj marked this pull request as ready for review June 16, 2021 21:42
@superherointj
Copy link
Contributor Author

Thou shall never start version attributes with non-numerical characters

Fixed.

@superherointj
Copy link
Contributor Author

This PR likely should be backported to stable at least. Because Linkerd is broken there. And shouldn't be.

superherointj referenced this pull request Jun 16, 2021
@zowoq
buildGo{Package,Module}: set trimpath in GOFLAGS
4e9f7bb 
Also drop removeReferencesTo

`-trimpath` removes all file system paths from the compiled executable,
this should improve reproducibility.
@superherointj @bryanasdev000
@jnetod @AndersonTorres
linkerd: 2020-05-01 -> edge-21.6.2
24b04ac 
linkerd.stable: init stable-2.9.5
linkerd.edge: init edge-21.6.2

Fixes #113218

This PR was a huge colaboration between many people: @NobbZ, @kalbasit, @tomberek, @ldesgoui, @Gonzih, @jnetod, @bryanasdev000, @AndersonTorres and more...
And @jnetod won the crown by being the last one to put the nail in the coffin!

Co-authored-by: bryanasdev000 <[email protected]>
Co-authored-by: jnetod <[email protected]>
Co-authored-by: AndersonTorres <[email protected]>
@SuperSandro2000

This comment has been minimized.

Sign in to view
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jun 16, 2021
bryanasdev000
bryanasdev000 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@bryanasdev000 bryanasdev000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Freaking awesome!

Tested it on a local cluster with some focus on template things, all working as expected.

+1 from me for backporting it, 21.05 do not need to keep a broken linkerd.

Thanks guys!

@SuperSandro2000
Copy link
Member

@ofborg eval

@superherointj
Copy link
Contributor Author

@SuperSandro2000 Is it possible to automatically backport this PR to stable? Should I add some label and the bot will do it? Is it okay?

@ofborg ofborg bot requested a review from bryanasdev000 June 16, 2021 23:43
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 127130 run on x86_64-linux 1

2 packages built:
  • linkerd
  • linkerd_stable

bryanasdev000
bryanasdev000 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@bryanasdev000 bryanasdev000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SuperSandro2000 SuperSandro2000 merged commit 1ffadaa into NixOS:master Jun 17, 2021
@github-actions github-actions bot mentioned this pull request Jun 17, 2021
Merged
@github-actions
Copy link
Contributor

Successfully created backport PR #127154 for release-21.05.

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jun 20, 2021
@superherointj superherointj deleted the package-linkerd-edge-21.6.2 branch June 23, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@bryanasdev000 bryanasdev000 bryanasdev000 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Gonzih Gonzih Awaiting requested review from Gonzih

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees

@superherointj superherointj

@bryanasdev000 bryanasdev000

Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linkerd-unstable contains no binary
6 participants
@superherointj @nixos-discourse @AndersonTorres @SuperSandro2000 @bryanasdev000 @cole-h