-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added YAML, JSON, python files for assimilating VIIRS satwinds #1055
Conversation
@BrettHoover-NOAA Thanks. Based on global_convinfo.txt The AMVs from VIIRS (Type 260 with satids 224, 225, and 226) have no thinning applied. (Yeh~). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments regarding some of the attributes, but otherwise look fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @nicholasesposito 's comment should not delay approval IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of commented lines in both the YAMLs that can be removed, otherwise looks good.
Approved on my end |
* develop: Visualize stats in simple html document (#1089) Time series of csv stats (#1086) Use the gdas bkg for the static B (#1084) Add module files to compile on AWS (#1082) The DA only uses the gdas bkg ... fixing again ... (#1079) Using ioda util to convert the datetime in AMSR2 converter (#1077) Add modulefile for Dogwood/Cactus (#1073) Addition of a switch for the cycling type (#1072) Added YAML, JSON, python files for assimilating VIIRS satwinds (#1055) No mpi for the ascii stats (#1070)
Adding satwinds from the Visible Infrared Imaging Radiometer Suite (VIIRS) from SNPP/NOAA-20 to GDASApp end-to-end testing
new files include:
parm/atm/obs/config/satwind_viirs_npp.yaml.j2: QC filter YAML for VIIRS SNPP satwinds (jinja2 standard)
parm/atm/obs/config/satwind_viirs_n20.yaml.j2: QC filter YAML for VIIRS NOAA-20 satwinds (jinja2 standard)
parm/ioda/bufr2ioda/bufr2ioda_satwind_amv_viirs.json: JSON containing data format, sensor, and satellite information for VIIRS SNPP/NOAA-20 satwinds
ush/ioda/bufr2ioda/bufr2ioda_satwind_amv_viirs.py: bufr2ioda code for extracting VIIRS SNPP/NOAA-20 satwinds from BUFR
See #1054 for end-to-end testing results. Acceptance and ob-errors agree well with some expected deviation. No thinning is applied to these winds by regular convention.
Note: We are still using
qualityInformationWithoutForecast
as the variable-name for QI in the IODA converter. This variable-name is currently not registered in the IODA ObsSpace.yaml, but there is an ongoing discussion with JCSDA to have it added, issue is here: https://github.com/JCSDA-internal/ioda/issues/1233