Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of a switch for the cycling type #1072

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Addition of a switch for the cycling type #1072

merged 3 commits into from
Apr 25, 2024

Conversation

guillaumevernieres
Copy link
Contributor

Draft because I still need to test this while cycling.

@guillaumevernieres
Copy link
Contributor Author

FYI @JessicaMeixner-NOAA , that "should" fix the current issue, but I have yet to test within a proper cycling test ...

@guillaumevernieres guillaumevernieres marked this pull request as ready for review April 24, 2024 19:58
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 24, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Apr 24, 2024
JessicaMeixner-NOAA
JessicaMeixner-NOAA requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have additional similar issue in gdasocnanalpost that also needs fixed.

apchoiCMD
apchoiCMD previously approved these changes Apr 24, 2024
View reviewed changes
@guillaumevernieres
Copy link
Contributor Author

As @JessicaMeixner-NOAA wrote above @apchoiCMD , it's still broken ... Working on a fix. I'm re-requesting reviews so we don't see green checks on the review side, if anything just block the pr.

@apchoiCMD
Copy link
Collaborator

As @JessicaMeixner-NOAA wrote above @apchoiCMD , it's still broken ... Working on a fix. I'm re-requesting reviews so we don't see green checks on the review side, if anything just block the pr.

Got it, I just assumed that you asked me to review again- @guillaumevernieres

AndrewEichmann-NOAA
AndrewEichmann-NOAA previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 24, 2024
@emcbot
Copy link

emcbot commented Apr 24, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Apr 24 17:35:59 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr 24 18:25:55 CDT 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Apr 24 18:55:31 CDT 2024
Tests: 100% tests passed, 0 tests failed out of 45

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 24, 2024
@JessicaMeixner-NOAA
Copy link
Collaborator

@guillaumevernieres I see regtests are running here. Has the additional bug-fix been added? Should I retest on my side?

@guillaumevernieres
Copy link
Contributor Author

guillaumevernieres commented Apr 25, 2024 •
edited
Loading

@guillaumevernieres I see regtests are running here. Has the additional bug-fix been added? Should I retest on my side?

Not yet @JessicaMeixner-NOAA . We try to emulate the cycling in our ctest, but it's not perfect. The ci should have failed. I'll try to have the fix today.
It didn't fail because we're not testing the "iau" cycling case.

JessicaMeixner-NOAA
JessicaMeixner-NOAA reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @guillaumevernieres my test now succeeded both failed jobs... gdasfcst is now running... I can report back with the full test has finished as well.

AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks oker

apchoiCMD
apchoiCMD approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guillaumevernieres

@guillaumevernieres guillaumevernieres merged commit 1b07517 into develop Apr 25, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the bugfix/wrong-ice-rst branch April 25, 2024 15:43
danholdaway added a commit that referenced this pull request May 2, 2024
@danholdaway
Merge branch 'develop' into feature/use_jcb_atm
6ef814f 
* develop:
  Visualize stats in simple html document (#1089)
  Time series of csv stats (#1086)
  Use the gdas bkg for the static B (#1084)
  Add module files to compile on AWS (#1082)
  The DA only uses the gdas bkg ... fixing again ... (#1079)
  Using ioda util to convert the datetime in AMSR2 converter (#1077)
  Add modulefile for Dogwood/Cactus (#1073)
  Addition of a switch for the cycling type (#1072)
  Added YAML, JSON, python files for assimilating VIIRS satwinds (#1055)
  No mpi for the ascii stats (#1070)
danholdaway added a commit that referenced this pull request May 3, 2024
@danholdaway
Merge branch 'develop' into feature/build_jedi_exe
6a9ae4f 
* develop:
  Using ioda util to convert the datetime in AMSR2 converter (#1077)
  Add modulefile for Dogwood/Cactus (#1073)
  Addition of a switch for the cycling type (#1072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@apchoiCMD apchoiCMD apchoiCMD approved these changes

Assignees
No one assigned
Labels
hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seaice analysis insertion is not correct when DO_IAU is switched on
5 participants
@guillaumevernieres @apchoiCMD @emcbot @JessicaMeixner-NOAA @AndrewEichmann-NOAA