24-Word Seed Phrases

[wjmelements]

Changes

This fixes #4358
It also allows other kinds of whitespace besides spaces, such as newlines.

[whymarrh]

Rebasing this on the latest develop should help with (some of) the build failures here

[wjmelements]

Besides my own testing, I have had two users verify that this works.

[wjmelements]

I am seeing "MetaMask: 'eth_accounts' unexpectedly updated accounts. Please report this bug." in the console logs. I'm not sure if that is from this change.

[wjmelements]

I do not see the above issue on 7.7.3. Trying develop.

[wjmelements]

Unfortunately the error message doesn't show every time.

The code for the error message is at node_modules/metamask-inpage-provider/index.js:436

[whymarrh]

@wjmelements thanks for this. Mind updating the PR title when you're ready? We can debug the bug above separately if you want to open an issue with repro steps.

[wjmelements]

I confirm that I also see the aforementioned issue on develop @ 712f3eb

[whymarrh]

Thanks @wjmelements, this has been a long time coming!

[wjmelements]

@whymarrh issue tracked here: MetaMask/providers#16

[urcades]

Quick Question: Does this merge add 24-word seed phrases to the chrome addon? I've been googling around because the current chrome addon definitely still does not support 24-word seeds.

In order to access a 24-seed-secured wallet do I need to build this on my own and run? Is there any timeline for inclusion of this feature in the chrome addon?

Thanks!

[wjmelements]

It does, but I don’t think the change has made it into production yet. You can build the develop branch locally to get it. The instructions are in the README. In developer mode of Chrome you can load a built extension unpacked.

…

On Sat, Feb 29, 2020 at 2:57 PM édouard ***@***.***> wrote: Quick Question: Does this merge add 24-word seed phrases to the chrome addon? I've been googling around because the current chrome addon definitely still does not support 24-word seeds. In order to access a 24-seed-secured wallet do I need to build this on my own and run? Is there any timeline for inclusion of this feature in the chrome addon? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7987?email_source=notifications&email_token=AAGDGVJG7IVDFPK3AJ6PNE3RFGJF3A5CNFSM4KQDW7T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMIFPQ#issuecomment-593003198>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGDGVIXCPB5KISJMICBZLLRFGJF3ANCNFSM4KQDW7TQ> .

[urcades]

@wjmelements Great to know, thank you!

[koredefashokun]

Is there a timeline for when this will get into production?

[whymarrh]

We're building up to a version 8 release in the next couple of weeks—this will be part of that

[hoch1minh]

Hi, I've been waiting for SO LONG for this update. I cannot access my wallet on metamask, because I have 24 word seed phrase. And I need to access it exactly with metamask because it's the only tool to log me in Decentraland. PLEASE HELP.

[Gudahtt]

@hoch1minh v8 has already been released, so MetaMask should now support 24-word seed phrases.

[hoch1minh]

just checked it and yes indeed, it worked! Thanks!

[Erycus]

Metamask extension still insists on a 12 word seed phrase.

[wjmelements]

I have read the CLA Document and I hereby sign the CLA