Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metamask-inpage-provider; minor fixes #7997

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Update metamask-inpage-provider; minor fixes #7997

merged 1 commit into from
Feb 6, 2020
+10 −10

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Feb 6, 2020

No description provided.

@rekmarks rekmarks requested a review from whymarrh February 6, 2020 15:15
Gudahtt
Gudahtt approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [9ebe981]
Page Load Metrics (631 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint348444105
domContentLoaded5827006293015
load5837026313015
domInteractive5817006293015

@rekmarks rekmarks merged commit 8e307f8 into develop Feb 6, 2020
@rekmarks rekmarks deleted the update-inpage-provider branch February 6, 2020 15:57
@whymarrh
Copy link
Contributor

whymarrh commented Feb 6, 2020

Hmm, @rekmarks could this have caused #7987 (comment)

@whymarrh
Copy link
Contributor

whymarrh commented Feb 6, 2020

The difference in code suggests it's unlikely, but maybe?

@wjmelements wjmelements mentioned this pull request Feb 6, 2020
Closed
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Feb 14, 2020
@rekmarks @yqrashawn
update inpage-provider; minor fixes (MetaMask#7997)
c752386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekmarks @metamaskbot @whymarrh @Gudahtt