Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wallet seeds longer than 12 words #4358

Closed
leafcutterant opened this issue May 24, 2018 · 7 comments · Fixed by #7987
Closed

Allow wallet seeds longer than 12 words #4358

leafcutterant opened this issue May 24, 2018 · 7 comments · Fixed by #7987
Labels
area-accounts Relating to how sensitive account data is managed and stored. area-seedPhrase type-enhancement

Comments

@leafcutterant
Copy link

leafcutterant commented May 24, 2018

I thought that Metamask conforms in this to the general usage of BIP39, but it seems that's not the case.

BIP39 mnemonics can be multiples of 3 words, which means there can also be 15, 18, 21 and 24 words long mnemonics. (I haven't seen anything above that.) People use them, one reason being that 24 words long mnemonics (256 bit entropy) are safe against quantum computation attacks.

My point is that right now Metamask won't let me through if my seed is longer than 12 words. This limits the user, and also compromises seed portability.

Could we have longer seeds accepted?

@Ratnaram12

This comment has been minimized.

@bdresser bdresser added type-enhancement P3-soon area-accounts Relating to how sensitive account data is managed and stored. area-seedPhrase labels Jun 5, 2018
@dh06IRL
Copy link

dh06IRL commented Aug 18, 2019

Would like to bump this a bit for consideration. 24 word mnemonics seem to be picking up traction so it'd be great from a user perspective to have support.

@Drive4ik
Copy link

My wallet has 24 words seed. And this is the only limitation that does not allow me to use MetaMask.
As far as I know, making support for 24 words should not be a lot of work, just the last keyword and its bits to calculate from the total number of words in seed. Still need to fix the translations)
Thank you very much in advance!

@wjmelements
Copy link
Contributor

👍

This would help with compatibility and shouldn't be too hard of a change

@wjmelements
Copy link
Contributor

It looks fairly easy to do this because the bip39 dependency already supports 24-word seed phrases.

@wjmelements
Copy link
Contributor

I have a WIP here

@asmodat
Copy link

asmodat commented Apr 1, 2020

Definitely need this feature, because it makes it incompatible with the ledger and importing old accounts which are by default 24 words

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accounts Relating to how sensitive account data is managed and stored. area-seedPhrase type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants