Updated translations based on English changes from core 22789 #22834

jrafanie · 2024-01-10T15:21:52Z

UI translations json files are in ManageIQ/manageiq-ui-classic#9015

ManageIQ/manageiq#22789 ManageIQ/manageiq#22834

Fryguy · 2024-01-10T15:39:37Z

locale/de/manageiq.po

@@ -10601,9 +10604,15 @@ msgstr "ConfigurationScript-Basis|Ausgabe"
 msgid "ConfigurationScriptBase|Payload"
 msgstr "ConfigurationScript-Basis|Nutzdaten"

+msgid "ConfigurationScriptBase|Payload error"
+msgstr "ConfigurationScript-Basis | Fehler bei Nutzdaten"


I think the spaces here might be incorrect. The | is not part of the string, but is a parsing separator.

Also the model name should not be translated. So, in total this should be

Suggested change

msgstr "ConfigurationScript-Basis | Fehler bei Nutzdaten"

msgstr "ConfigurationScriptBase|Fehler bei Nutzdaten"

It should be trivial to add specs that check this, so I'm wondering if we should do that.

FWIW in gettext terminology this prefix thing is called a "context". See here for an example of it in the gettext ruby gem README: https://github.com/ruby-gettext/gettext#sp_-or-spgettext-context-aware-pluralized

Another link: https://www.gnu.org/software/gettext/manual/html_node/Contexts.html

Fryguy · 2024-01-10T15:41:55Z

locale/de/manageiq.po

+msgid "Invalid button action!"
+msgstr "Ungültige Schaltflächenaktion!"


This string was removed, so is this just from an old run?

Fryguy · 2024-01-10T15:42:54Z

locale/fr/manageiq.po

@@ -26895,6 +26901,9 @@ msgstr "Identifiants d'authentification non valides"
 msgid "Invalid button action"
 msgstr "Action de bouton non valide"

+msgid "Invalid button action!"
+msgstr "Action de bouton non valide !"


Space before the !? (doesn't matter cause this should go away, I'm just surprised)

fixed anyway

jrafanie · 2024-01-10T21:20:33Z

locale/ja/manageiq.po

 msgid "ConfigurationScriptBase|Payload type"
 msgstr "ConfigurationScript ベース | ペイロード・タイプ"

+msgid "ConfigurationScriptBase|Payload valid"
+msgstr "ConfigurationScriptベース | ペイロード有効"


Looks like base was translated here too. 😢

and space around pipe

jrafanie · 2024-01-10T21:22:50Z

locale/zh_CN/manageiq.po

@@ -25389,6 +25395,9 @@ msgstr "无效验证证书"
 msgid "Invalid button action"
 msgstr "无效的按钮操作"

+msgid "Invalid button action!"
+msgstr "按钮操作无效！"


ugh, space after !

lol, https://www.codetable.net/decimal/65281

That's a unicode ! with a deceptively large amount of visual space after it. Keeping it even if my 👀 don't like the extra space.

jrafanie · 2024-01-10T21:23:31Z

locale/zh_CN/manageiq.po

 msgid "ConfigurationScriptBase|Payload type"
 msgstr "ConfigurationScriptBase | 有效内容类型"

+msgid "ConfigurationScriptBase|Payload valid"
+msgstr "ConfigurationScriptBase | 有效内容"


ugh, looks like we had spaces after base in the existing translations... probably why they did the same here.

jrafanie · 2024-01-10T21:24:46Z

locale/pt_BR/manageiq.po

 msgid "ConfigurationScriptBase|Payload type"
 msgstr "ConfigurationScriptBase | Tipo de carga útil"

+msgid "ConfigurationScriptBase|Payload valid"
+msgstr "ConfigurationScriptBase | Carga útil válida"


Same as others, space was after Base in the existing translations, so they did it again.

Fryguy · 2024-01-10T21:25:15Z

locale/es/manageiq.po

@@ -26929,6 +26935,9 @@ msgstr "Credenciales de autenticación no válidas"
 msgid "Invalid button action"
 msgstr "Acción de botón no válida"

+msgid "Invalid button action!"
+msgstr "Acción de botón no válida."


Just noticed this is missing the ! (and since it's Spanish, the leading ¡). Again, doesn't matter cause it's going to go away.

jrafanie · 2024-01-10T21:25:44Z

locale/ko/manageiq.po

 msgid "ConfigurationScriptBase|Payload type"
 msgstr "ConfigurationScriptBase|페이로드 유형"

+msgid "ConfigurationScriptBase|Payload valid"
+msgstr "ConfigurationScriptBase | 페이로드 유효"


Space around pipe 😢

jrafanie · 2024-01-10T21:28:10Z

locale/es/manageiq.po

 msgid "ConfigurationScriptBase|Payload type"
 msgstr "ConfigurationScriptBase|Tipo de carga útil"

+msgid "ConfigurationScriptBase|Payload valid"
+msgstr "ConfigurationScriptBase | Carga útil válida"


space around pipe

will need to make sure the translators get this change we did manually, along with the others.

miq-bot · 2024-01-11T21:10:20Z

Checked commits jrafanie/manageiq@f59757b~...0b0f665 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

jrafanie · 2024-01-11T21:17:17Z

locale/zh_TW/manageiq.po

@@ -25397,6 +25403,9 @@ msgstr "鑑別認證無效"
 msgid "Invalid button action"
 msgstr "按鈕動作無效"

+msgid "Invalid button action!"
+msgstr "按鈕動作無效！"


unicode 65281 again 🤣

Fryguy · 2024-01-11T21:17:19Z

@jrafanie What do you think about adding some automated specs for checking these cases? (Not for this PR, just in general)

jrafanie · 2024-01-11T21:28:31Z

@jrafanie What do you think about adding some automated specs for checking these cases? (Not for this PR, just in general)

I think we need to better understand if the msgstr should have the leading context Model at all. I'm not sure if I'm understanding it correctly, but it seems like the context should be prefixed in the msgid or in the msgctxt although I think we only use msgid format with Model|column syntax. Either way, I think the msgstr should be just the translated string in that context. 🤷 We should discuss.

https://www.gnu.org/software/gettext/manual/html_node/Contexts.html

jrafanie · 2024-01-11T21:31:11Z

FYI, ManageIQ/manageiq-ui-classic#9015 has been updated with the latest changes from here. Note, my fixes are to all translations (8) but english and italian and only the json files for the 8 locales are updated in my subsequent commit there. So, I think they're both ready to go.

Fryguy · 2024-01-12T14:21:55Z

Backported to quinteros in commit b62cde7.

commit b62cde79c3df899235fcd278e803db59a300312c
Author: Jason Frey <[email protected]>
Date:   Fri Jan 12 09:21:21 2024 -0500

    Merge pull request #22834 from jrafanie/updated_translations_based_on_22789
    
    Updated translations based on English changes from core 22789
    
    (cherry picked from commit 140e6660189b665526e9d7a588b9433d0aaf59e7)

…_22789 Updated translations based on English changes from core 22789 (cherry picked from commit 140e666)

Updated translations based on English changes from core 22789

f59757b

ManageIQ#22789

jrafanie added internationalization quinteros/yes labels Jan 10, 2024

jrafanie assigned Fryguy Jan 10, 2024

jrafanie requested a review from Fryguy as a code owner January 10, 2024 15:21

jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request Jan 10, 2024

Updated ui json files based on core 22789 and 22834

559e3c3

ManageIQ/manageiq#22789 ManageIQ/manageiq#22834

jrafanie mentioned this pull request Jan 10, 2024

Updated ui translation json files based on core 22789 and 22834 ManageIQ/manageiq-ui-classic#9015

Merged

Fryguy reviewed Jan 10, 2024

View reviewed changes

jrafanie commented Jan 10, 2024

View reviewed changes

Fryguy reviewed Jan 10, 2024

View reviewed changes

jrafanie commented Jan 10, 2024

View reviewed changes

jrafanie added 2 commits January 11, 2024 16:07

Don't translate model name / gettext context

a8f4fb8

Remove spaces, particularly around gettext contexts

0b0f665

jrafanie commented Jan 11, 2024

View reviewed changes

Fryguy approved these changes Jan 11, 2024

View reviewed changes

Fryguy merged commit 140e666 into ManageIQ:master Jan 12, 2024
6 checks passed

Fryguy added a commit that referenced this pull request Jan 12, 2024

Merge pull request #22834 from jrafanie/updated_translations_based_on…

b62cde7

…_22789 Updated translations based on English changes from core 22789 (cherry picked from commit 140e666)

Fryguy added quinteros/backported and removed quinteros/yes labels Jan 12, 2024

jrafanie deleted the updated_translations_based_on_22789 branch January 16, 2024 20:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated translations based on English changes from core 22789 #22834

Updated translations based on English changes from core 22789 #22834

jrafanie commented Jan 10, 2024 •

edited

Loading

Fryguy Jan 10, 2024

Fryguy Jan 10, 2024

Fryguy Jan 10, 2024

Fryguy Jan 10, 2024

Fryguy Jan 10, 2024

jrafanie Jan 10, 2024

Fryguy Jan 10, 2024

jrafanie Jan 11, 2024

jrafanie Jan 10, 2024

jrafanie Jan 10, 2024

jrafanie Jan 11, 2024

jrafanie Jan 10, 2024

jrafanie Jan 11, 2024

jrafanie Jan 10, 2024

jrafanie Jan 11, 2024

jrafanie Jan 10, 2024

jrafanie Jan 11, 2024

Fryguy Jan 10, 2024

jrafanie Jan 10, 2024

jrafanie Jan 11, 2024

jrafanie Jan 10, 2024

jrafanie Jan 11, 2024

miq-bot commented Jan 11, 2024

jrafanie Jan 11, 2024

Fryguy commented Jan 11, 2024

jrafanie commented Jan 11, 2024 •

edited

Loading

jrafanie commented Jan 11, 2024

Fryguy commented Jan 12, 2024

	msgstr "ConfigurationScript-Basis \| Fehler bei Nutzdaten"
	msgstr "ConfigurationScriptBase\|Fehler bei Nutzdaten"

		msgid "Invalid button action!"
		msgstr "Ungültige Schaltflächenaktion!"

Updated translations based on English changes from core 22789 #22834

Updated translations based on English changes from core 22789 #22834

Conversation

jrafanie commented Jan 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miq-bot commented Jan 11, 2024

Choose a reason for hiding this comment

Fryguy commented Jan 11, 2024

jrafanie commented Jan 11, 2024 • edited Loading

jrafanie commented Jan 11, 2024

Fryguy commented Jan 12, 2024

jrafanie commented Jan 10, 2024 •

edited

Loading

jrafanie commented Jan 11, 2024 •

edited

Loading