Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English Translations 2023-12-26T17:22:29Z #22789

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

miq-bot
Copy link
Member

@miq-bot miq-bot commented Nov 15, 2023

Update the English Translations in the manageiq.po and manageiq.pot files.

@jrafanie jrafanie self-assigned this Nov 16, 2023
@miq-bot miq-bot changed the title Update English Translations 2023-11-08T18:59:09Z Update English Translations 2023-11-24T19:14:35Z Dec 1, 2023
@miq-bot miq-bot force-pushed the update_english_translations branch 2 times, most recently from d09db88 to 78d5c94 Compare December 4, 2023 14:47
@miq-bot miq-bot changed the title Update English Translations 2023-11-24T19:14:35Z Update English Translations 2023-12-04T18:08:37Z Dec 15, 2023
@miq-bot miq-bot force-pushed the update_english_translations branch from 78d5c94 to 56c64d1 Compare December 15, 2023 00:20
@miq-bot miq-bot changed the title Update English Translations 2023-12-04T18:08:37Z Update English Translations 2023-12-26T17:22:29Z Jan 1, 2024
@miq-bot miq-bot force-pushed the update_english_translations branch from 56c64d1 to 785bd07 Compare January 1, 2024 00:19
@miq-bot
Copy link
Member Author

miq-bot commented Jan 1, 2024

Checked commit miq-bot@785bd07 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@@ -27756,15 +27756,15 @@ msgstr ""
msgid "Edit Sequence of User Groups was cancelled by the user"
msgstr ""

#: ../app/controllers/service_controller.rb
msgid "Edit Service \"%{name}\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good bug fix

@@ -7952,6 +7952,10 @@ msgstr ""
msgid "Automation Managers (Ansible Tower)"
msgstr ""

#: ../app/javascript/spec/textual_summary/data/code_mirror_data.js
msgid "Automation Method Data"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New string

#: ../config/model_attributes.rb
msgid "ConfigurationScriptBase|Payload type"
msgstr ""

#: ../config/model_attributes.rb
msgid "ConfigurationScriptBase|Payload valid"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like two new columns

@@ -22135,11 +22146,6 @@ msgstr ""
msgid "Default Value"
msgstr ""

#. TRANSLATORS: file: db/fixtures/miq_product_features.yml
#: ../config/yaml_strings.rb
msgid "Default Views"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed via #22797

@@ -29989,6 +29989,10 @@ msgstr ""
msgid "Editing tag mapping from label \"%{name}\""
msgstr ""

#: ../app/javascript/components/MarkdownPreview/index.jsx
msgid "Editor"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the editor tab title from ManageIQ/manageiq-ui-classic#8972

@@ -39402,6 +39404,10 @@ msgstr ""
msgid "Invalid button action"
msgstr ""

#: ../app/controllers/service_controller.rb
msgid "Invalid button action!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but should this match the one above ☝️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, one has a ! - probably should be changed to match. good 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffibm @DavidResende0 can you take a look at normalizing these values? It's very low urgency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged

@@ -49362,11 +49369,6 @@ msgstr ""
msgid "Name"
msgstr ""

#: ../app/helpers/catalog_helper.rb
#: ../app/views/catalog/_form_basic_info.html.haml
msgid "Name / Description"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, comes from ManageIQ/manageiq-ui-classic#8975

msgstr ""

#: ../app/helpers/task_details_helper.rb
msgid "Task ID"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -72595,10 +72611,6 @@ msgstr ""
msgid "Textual"
msgstr ""

#: ../app/helpers/configuration_helper/configuration_view_helper.rb
msgid "Textual View"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -78963,6 +78976,11 @@ msgstr ""
msgid "View More"
msgstr ""

#. TRANSLATORS: file: db/fixtures/miq_product_features.yml
#: ../config/yaml_strings.rb
msgid "View My Settings"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from #22779

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nitpick below re: Invalid button action! that we can handle later on.

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit 6c2ef4a into ManageIQ:master Jan 5, 2024
6 checks passed
@Fryguy
Copy link
Member

Fryguy commented Jan 5, 2024

Backported to quinteros in commit fc5874a.

commit fc5874ac68c77635f24e9c00e298911e75942945
Author: Joe Rafaniello <[email protected]>
Date:   Fri Jan 5 11:51:19 2024 -0500

    Merge pull request #22789 from miq-bot/update_english_translations
    
    Update English Translations 2023-12-26T17:22:29Z
    
    (cherry picked from commit 6c2ef4a5a2f066a7195815ee10bd9114e861e323)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants