Add support for Featured Posts #2585

makotech222 · 2022-11-24T02:11:14Z

This is the backend changes for adding Featured Posts (Local and Community) (#2067). Summary of changes below:

General rename of Sticky -> Feature, where appropriate
Add featured_community and featured_local database fields to Post/PostAggregates
Update 'FeaturePost' endpoint to differentiate between local/community featuring.
Update PostQuery to order correctly for featured posts in Local/Community view

Only current uncertainty is around changes in apub, please give guidance on whether I did it properly or not.

Once this PR is approved, I will make the PRs for the frontend changes, and merge all at once.

Thanks!

Child PRS:

Nutomic · 2022-11-24T11:54:19Z

src/api_routes.rs

@@ -181,7 +181,7 @@ pub fn config(cfg: &mut web::ServiceConfig, rate_limit: &RateLimitCell) {
            web::post().to(route_post::<MarkPostAsRead>),
          )
          .route("/lock", web::post().to(route_post::<LockPost>))
-          .route("/sticky", web::post().to(route_post::<StickyPost>))
+          .route("/feature_post", web::post().to(route_post::<FeaturePost>))


This is a breaking change, might be better to leave it for later.

The data structure is also breaking, we can just wait to merge until after 0.17.0

So leave the route as "/sticky"?

Nutomic · 2022-11-24T11:56:19Z

crates/db_views/src/post_view.rs

        published: agg.published,
        newest_comment_time_necro: inserted_post.published,
        newest_comment_time: inserted_post.published,
+        featured_community: false,
+        featured_local: false,


You can probably do ..Default::default() and remove explicit values like featured_local: false, score: 0 etc

I'll leave that for future work, as none of the other structs are doing this currently it seems like.

migrations/2022-11-20-032430_sticky_local/up.sql

Nutomic · 2022-11-24T11:59:42Z

crates/db_schema/src/lib.rs

@@ -82,7 +82,7 @@ pub enum ModlogActionType {
  All,
  ModRemovePost,
  ModLockPost,
-  ModStickyPost,
+  ModFeaturePost,


You will also have to add a mod log entry for AdminFeaturePost.

Using the existing table is pry better, then you don't have to do the views again.

I can always add another column to differentiate between local/community feature?

crates/api_common/src/post.rs

crates/apub/src/protocol/objects/page.rs

crates/db_schema/src/impls/post.rs

dessalines · 2022-11-24T13:53:11Z

src/api_routes.rs

@@ -181,7 +181,7 @@ pub fn config(cfg: &mut web::ServiceConfig, rate_limit: &RateLimitCell) {
            web::post().to(route_post::<MarkPostAsRead>),
          )
          .route("/lock", web::post().to(route_post::<LockPost>))
-          .route("/sticky", web::post().to(route_post::<StickyPost>))
+          .route("/feature_post", web::post().to(route_post::<FeaturePost>))


The data structure is also breaking, we can just wait to merge until after 0.17.0

src/api_routes.rs

dessalines · 2022-11-24T14:01:48Z

crates/db_schema/src/lib.rs

@@ -82,7 +82,7 @@ pub enum ModlogActionType {
  All,
  ModRemovePost,
  ModLockPost,
-  ModStickyPost,
+  ModFeaturePost,


Using the existing table is pry better, then you don't have to do the views again.

crates/db_views_moderator/src/mod_feature_post_view.rs

migrations/2022-11-20-032430_sticky_local/up.sql

dessalines · 2022-12-01T21:59:26Z

migrations/2022-11-20-032430_sticky_local/up.sql

+alter table post_aggregates DROP COLUMN stickied;
+
+alter table mod_sticky_post
+rename column stickied TO featured;


This still needs some column to differentiate between local and community. Can be a boolean, or an enum, your choice.

Fixed with 'is_featured_community' bool on table

dessalines

Looks good.

dessalines · 2022-12-02T17:05:35Z

crates/db_schema/src/schema.rs

        id -> Int4,
        mod_person_id -> Int4,
        post_id -> Int4,
-        stickied -> Nullable<Bool>,
+        is_featured_community -> Bool,


Hope these are in the correct order, not sure if compile would fail if they're not.

haha it compiled, but when reading from the database the bools were in the wrong place. I just ran into the bug while testing today lol

dessalines · 2022-12-02T17:07:06Z

I'll make sure @Nutomic approve too before merging.

Nutomic · 2022-12-02T22:10:43Z

crates/apub/src/objects/post.rs

        embed_title,
        embed_description,
        embed_video_url,
        thumbnail_url,
        ap_id: Some(page.id.clone().into()),
        local: Some(false),
        language_id,
+        featured_community: page.stickied,
+        featured_local: Some(false),


Its possible that a local admin features a remote post. In case the post creator edits the post, this would overwrite the value for featured. You should just set None here so it keeps the existing value.

Nutomic · 2022-12-02T22:10:59Z

crates/apub/src/objects/post.rs

@@ -227,7 +228,8 @@ impl ApubObject for ApubPost {
        .community_id(community.id)
        .ap_id(Some(page.id.clone().into()))
        .locked(page.comments_enabled.map(|e| !e))
-        .stickied(page.stickied)
+        .featured_community(page.stickied)
+        .featured_local(Some(false))


Same here (you can just remove the line).

Nutomic · 2022-12-05T12:54:51Z

CI wasnt working properly for this repo, hopefully its fixed now. Anyway there is a clippy error that needs to be fixed:

error: you are deriving `PartialEq` and can implement `Eq`
--> crates/db_schema/src/lib.rs:100:84
|
100 | #[derive(EnumString, Display, Debug, Serialize, Deserialize, Clone, Copy, Default, PartialEq)]
|                                                                                    ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= note: `-D clippy::derive-partial-eq-without-eq` implied by `-D clippy::style`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

makotech222 · 2022-12-05T23:45:34Z

Looks like the federation tests have failed. Looks like this will have to wait until the lemmy-js-client is updated.

makotech222 requested review from Nutomic and dessalines as code owners November 24, 2022 02:11

Nutomic reviewed Nov 24, 2022

View reviewed changes

dessalines reviewed Nov 24, 2022

View reviewed changes

makotech222 force-pushed the featuredposts branch from bac4bab to 2e3ef32 Compare December 1, 2022 16:06

This was referenced Dec 1, 2022

Add FeaturePost support LemmyNet/lemmy-js-client#88

Merged

Add FeaturedPosts support LemmyNet/lemmy-ui#873

Merged

Add Featured Post translations LemmyNet/lemmy-translations#31

Merged

dessalines reviewed Dec 1, 2022

View reviewed changes

makotech222 force-pushed the featuredposts branch from 3a50f0c to 8a337f8 Compare December 2, 2022 16:13

dessalines approved these changes Dec 2, 2022

View reviewed changes

Nutomic reviewed Dec 2, 2022

View reviewed changes

Nutomic approved these changes Dec 3, 2022

View reviewed changes

Nutomic enabled auto-merge (squash) December 3, 2022 20:00

Nutomic disabled auto-merge December 5, 2022 10:56

Nutomic enabled auto-merge (squash) December 5, 2022 12:55

auto-merge was automatically disabled December 5, 2022 15:28
Head branch was pushed to by a user without write access

Nutomic enabled auto-merge (squash) December 5, 2022 15:36

auto-merge was automatically disabled December 5, 2022 21:25
Head branch was pushed to by a user without write access

makotech222 force-pushed the featuredposts branch from ecca940 to 11d6eaf Compare December 11, 2022 17:29

Add support for Featured Posts

03cf988

makotech222 force-pushed the featuredposts branch from 11d6eaf to 03cf988 Compare December 11, 2022 17:32

makotech222 added 2 commits December 11, 2022 11:32

Fix rebase

ddd60e8

More fixes

81e2e15

dessalines approved these changes Dec 11, 2022

View reviewed changes

Nutomic merged commit 9dfd819 into LemmyNet:main Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Featured Posts #2585

Add support for Featured Posts #2585

makotech222 commented Nov 24, 2022 •

edited

Loading

Nutomic Nov 24, 2022

dessalines Nov 24, 2022

makotech222 Nov 24, 2022

Nutomic Nov 24, 2022

makotech222 Dec 1, 2022

Nutomic Nov 24, 2022

dessalines Nov 24, 2022

makotech222 Nov 25, 2022

dessalines Nov 24, 2022

dessalines Nov 24, 2022

dessalines Dec 1, 2022

makotech222 Dec 2, 2022

dessalines left a comment

dessalines Dec 2, 2022

makotech222 Dec 2, 2022

dessalines commented Dec 2, 2022

Nutomic Dec 2, 2022

makotech222 Dec 3, 2022

Nutomic Dec 2, 2022

makotech222 Dec 3, 2022

Nutomic commented Dec 5, 2022 •

edited

Loading

makotech222 commented Dec 5, 2022

Add support for Featured Posts #2585

Add support for Featured Posts #2585

Conversation

makotech222 commented Nov 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dessalines left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dessalines commented Dec 2, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nutomic commented Dec 5, 2022 • edited Loading

makotech222 commented Dec 5, 2022

makotech222 commented Nov 24, 2022 •

edited

Loading

Nutomic commented Dec 5, 2022 •

edited

Loading