Add FeaturePost support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Dec 1, 2022
src/interfaces/source.ts
Outdated
| id: number; | ||
| mod_person_id: number; | ||
| post_id: number; | ||
| @Transform(({ value }) => toOption(value), { toClassOnly: true }) | ||
| @Transform(({ value }) => toUndefined(value), { toPlainOnly: true }) | ||
| @Expose() | ||
| stickied: Option<boolean>; | ||
| featured: Option<boolean>; |
There was a problem hiding this comment.
Hrm.. this doesn't seem to make much sense for it to be optional. Better check the back end. Also I'll wait on merging cause the back-end still needs the local / community differentiation.
There was a problem hiding this comment.
I was thinking the same thing, wasn't sure why it was optional. Ill change it in that case.
There was a problem hiding this comment.
Once that's ready to go, I can merge and you should be able to fix the federation tests for LemmyNet/lemmy#2585
There was a problem hiding this comment.
Done. Forgot to push it, loll.
|
@dessalines Sorry, could you push a new version in the package.json? I probably should have done that in this PR. |
|
My bad, done: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See LemmyNet/lemmy#2585