Add FeaturedPosts support #873
Conversation
|
One last design issue I have currently is when to display the 'pin' icon when displaying the post. We can view a Post from multiple places throughout the app, Home, Community, Search, etc. Currently, if a post is 'Featured in Community', it will show the pin icon, even when viewing from outside the community. Should we differentiate when viewing a post from multiple places? Should I just display the 'pin' icon if its either community or local featured?
|
|
@dessalines tagging you here, sorry if its doubled up. for the question above. |
|
@Nutomic tagging, any thoughts on the two issues above? |
|
It should definitely not use the same icon, thats very confusing. If you cant find a fitting icon, why not put a text button like the one currently used for "remove"? |
|
Hrm... it doesn't matter to me, but probably not text. Different color pin icons should work, text-primary and text-secondary. |
|
Okay ill try different color pins. How about the other issue? On showing pinned icon? |
|
It pry makes sense to show the community pin, even if you're viewing it from the front page. No need to create rules around when to show it IMO. |
|
Okay, here's text-primary for community feature, text-secondary for local feature:
For the buttons, they are all 'text-muted', so maybe a different color might not be visually pleasing:
I could add text to the buttons:
Otherwise, we need a new icon. I asked in the lemmy chat, but couldn't get a good list of icons that are actually imported. What icons are available to use? |
|
Looks fine to me, but maybe they should be hidden behind the 3-dot menu. Up to you tho. |
|
The three-dot button is already expanded, and the pin icons only show when expanded. Also, which one looks good? Text with icon? |
|
Yeah text with icon is fine. |
makotech222
force-pushed
the
featuredposts
branch
2 times, most recently
from
0875adb to
84568cb
Compare
makotech222
force-pushed
the
featuredposts
branch
from
84568cb to
371174c
Compare
|
Okay should be ready to go then! Thanks! |
See LemmyNet/lemmy#2585
Adds a new 'Pin' icon to pin to Local view
Marking as draft, as its still a bit unfinished.
Also, soliciting feedback on what the Icon should look like. I'm not a fan of both 'pin to community' and 'pin to local' having the same icon. Not sure what other icons are available currently.