Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mark post as read button #1135

Closed
wants to merge 34 commits into from
Closed

Feature/mark post as read button #1135

wants to merge 34 commits into from

Conversation

ItsEcholot
Copy link

Fixes #384

dessalines and others added 30 commits February 21, 2023 16:03
@dessalines
Fix issue with empty markdown content not nulling DB. Fixes #924 (#925)
fec9200 
* Fix issue with empty markdown content not nulling DB. Fixes #924

* Better syntax
@dessalines
Remove buggy navbar search. Fixes #921 (#950)
a5569bb
@dessalines
Do local community checks for buttons. Fixes #918 (#948)
b9fbfab
@dessalines
Fixing line formatting. (#947)
7721d41
@dessalines
Adding a warning for deselecting the undetermined language. (#945)
cc76092 
- Fixes #930
@dessalines
Let any mod feature and lock posts. Fixes #875 (#944)
0375d71 
* Let any mod feature and lock posts. Fixes #875

* Change to amAdmin
@dessalines
Check to make sure post is correct. Fixes #934 (#949)
e5ced4f
@dessalines
Adding reports send email to admins option (#932)
79cbeac
@dessalines
Upgrading deps (#951)
53c2de0
@dessalines
Adding ban_from_community to be more clear. Fixes #872 (#943)
e58d61b
@dessalines
v0.17.2-rc.1
a119ba5
@dessalines
Only show the determined warning for multiple. (#952)
abb6d80
@dessalines
v0.17.2-rc.2
81493f9
@dessalines
v0.17.2
9e58f65
@SleeplessOne1917 @dessalines
I18 quality of life change (#973)
70f285f 
* I18 quality of life change

* Cleanup
@SleeplessOne1917 @dessalines
Handle when logged out (#986)
a2bcc37 
* Add logged out messages to profile and community

* Remove errors when not logged in

* Add logged out translations
@SleeplessOne1917 @dessalines
Get rid of "No Results" showing while search is still loading. (#997)
8fe83a2
@SleeplessOne1917 @dessalines
Add content warning to modlog and fix modlog routing bug (#994)
d52c549 
* Add content warning to modlog and fix modlog routing bug

* Add translation logic
@dessalines
Adding a warning for deselecting the undetermined language. (#945)
c2325ba 
- Fixes #930
@dessalines
Fixing some outdated docs links. Fixes #1006 (#1007)
91b3616
@dessalines
Show parent comment for comment link. Fixes #1030 (#1032)
c164881 
* Show parent comment for comment link. Fixes #1030

* Changing let to const.
@SleeplessOne1917 @dessalines
Show language on posts and comments (#1026)
1717b5c 
* Show language on posts and comments

* Revert "Show language on posts and comments"

This reverts commit 5426790.

* Change language indicator look
@Nutomic @dessalines
Remove "banned" badge from posts and comments (fixes 899) (#1011)
d6d249c 
It doesnt need to be emphasized so much that a user is banned.
Anyway this can already be seen in the mod log. For users who
are banned from the entire site it is still shown on the profile.

Co-authored-by: Dessalines <[email protected]>
@Nutomic @dessalines
Dont preselect new post language (#1008)
ade413c 
Lemmy-ui currently preselects the first language in the user
settings when creating a new post or comment. This is a bad
idea because this language might not actually be allowed in
the community. It is better to pass the language as None if
the user didnt specify it explicitly, because then the backend
can smartly choose a language based on the overlap of user
languages and community languages.

This fixes the problem described in
[this thread](https://lemmy.ml/post/1066608), where a user
tries to post in a community that has only English allowed,
with all languages enabled in user settings. In this case
lemmy-ui preselects "undetermined language" as default, which
is not allowed and results in an error. This PR fixes the issue
because it lets the backend automatically select the correct
language (English).
@SleeplessOne1917 @dessalines
Merge pull request #1036 from LemmyNet/language-tag-changes
078e940 
Changes to language tag
@dessalines
v0.17.3
c5006cc
@0xDEADCADE @dessalines
Fix isoData can contain user generated content (#1114)
32f5120 
* Fix isoData can contain user generated content

* Fix formatting
@dessalines
Try sanitize 1.
28c43a2
@dessalines
Fixing quotes.
55d26fc
@ItsEcholot
Add mark as read button in PostListing
cab3abb
@SleeplessOne1917
Copy link
Member

There are a bunch of changes from old commits showing up in this PR.

@ItsEcholot
Copy link
Author

This is because I had to use branch release/0.17 while developing since the UI on main and BE on main and/or BE on 0.17 and UI on main aren’t compatible.
We can try to merge this into 0.17 if you want. Else I’m open to suggestions.

@SleeplessOne1917
Copy link
Member

I'll try pulling this branch and merging main into it since the latest changes work on my machine.

@SleeplessOne1917
Copy link
Member

@ItsEcholot I did a merge. Can you allow me to push changes to this branch?

@ItsEcholot
Copy link
Author

@SleeplessOne1917 Sure, sent you an invite to the fork.

SleeplessOne1917
SleeplessOne1917 reviewed Jun 11, 2023
View reviewed changes
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the other comments I left, I'm gonna hold off on thinking about merging this until the websocket API removal has hit main.

src/shared/components/community/create-community.tsx Outdated Show resolved Hide resolved
src/shared/components/post/create-post.tsx Outdated Show resolved Hide resolved
src/shared/components/post/post-listing.tsx
@@ -750,6 +752,25 @@ export class PostListing extends Component<PostListingProps, PostListingState> {
);
}

get markReadButton() {
const read = this.props.post_view.read;
const label = read ? i18n.t("mark read") : i18n.t("mark unread");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't put spaces in the translation strings. Use mark_read and mark_unread instead.

src/shared/components/post/post-listing.tsx Show resolved Hide resolved
dessalines
dessalines reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the types of features that should be waiting till after our HTTP rework. I'd just put this on hold until then, and then rebase it. Shouldn't be more than a few days.

package.json Outdated Show resolved Hide resolved
@SleeplessOne1917
Copy link
Member

@ItsEcholot there are some merge conflicts that need handling before this can be merged.

@ItsEcholot
Copy link
Author

ItsEcholot commented Jun 17, 2023 •
edited
Loading

I did some basic merging but didn't have time to test the functionality atm... If someone else wants to do some testing and fixing (CI errors as well) it would be appreciated, else I'm gonna get around to it myself some time in the future.

@dessalines
Copy link
Member

Closing as this is stale and needs a rebase.

@dessalines dessalines closed this Jul 12, 2023
@ItsEcholot ItsEcholot deleted the feature/mark-post-as-read-button branch July 13, 2023 14:06
@milandamen milandamen mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines left review comments

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A post action button to hide posts
5 participants
@ItsEcholot @SleeplessOne1917 @dessalines @Nutomic @0xDEADCADE