Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when logged out #986

Merged
merged 3 commits into from
May 3, 2023

Conversation

SleeplessOne1917
Copy link
Member

This is for #975.

The community sidebar shows this when logged out:
logged out community sidebar

The profile page looks like this:
logged out profile

The text being used isn't final and I'll gladly change it if anyone has any better ideas. The alerts seems somewhat bland at the moment too. Maybe there should be an icon to go with them?

I have also made a version of this PR where I hide the create post and create community buttons. I will make a separate PR for that.

@SleeplessOne1917
Copy link
Member Author

@dessalines Are there any other changes this needs before it's good to merge?

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks! I apologize it took me a while to get to this.

@dessalines dessalines merged commit 2e78191 into LemmyNet:main May 3, 2023
dessalines pushed a commit that referenced this pull request May 4, 2023
* Add logged out messages to profile and community

* Remove errors when not logged in

* Add logged out translations
@SleeplessOne1917 SleeplessOne1917 deleted the logged-out-experience branch May 11, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants