Fix isoData can contain user generated content #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My local version of Prettier isn't complaining about this source. I don't usually do JS development, so I don't know what exactly could be wrong here. Does anyone else know, maybe @dessalines? |
|
Try running ’prettier . --write’ and see if that changes anything. Also try running ’yarn lint’. |
dessalines
approved these changes
Jun 8, 2023
|
@0xDEADCADE I'll handle the formatting in one sec. |
|
It was actually fine, just a CI issue. |
|
I would recommend doing a release with this fix relatively soon, and urging instance owners to update. The potential impact of this is high (see my Matrix DMs, or for anyone else, once this is in release, ask me at @deadcade:deadca.de on Matrix), and with the new wave of users, it would leave a very bad first impression. |
dessalines
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Fix isoData can contain user generated content * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.