Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for hf 15 (view tags) #110

Merged
merged 11 commits into from
Jul 27, 2022
Merged

support for hf 15 (view tags) #110

merged 11 commits into from
Jul 27, 2022

Conversation

fbeutin-ledger
Copy link
Contributor

No description provided.

@fbeutin-ledger fbeutin-ledger self-assigned this Jul 13, 2022
selsta
selsta reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a change src/monero_init.c:180 to support v0.18.0. and tests/test_version.py also needs to be updated to only support v0.18.

@fbeutin-ledger fbeutin-ledger force-pushed the j-berman-hf-v15 branch 3 times, most recently from a4a03b0 to 4f59019 Compare July 25, 2022 09:19
@fbeutin-ledger fbeutin-ledger force-pushed the j-berman-hf-v15 branch 3 times, most recently from 0a6924e to 766425e Compare July 26, 2022 07:12
j-berman
j-berman approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@j-berman j-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this here: j-berman#1

@j-berman j-berman mentioned this pull request Jul 27, 2022
Merged
@fbeutin-ledger fbeutin-ledger merged commit 31772fd into develop Jul 27, 2022
@jibeee jibeee mentioned this pull request Aug 3, 2022
Merged
@lpascal-ledger lpascal-ledger deleted the j-berman-hf-v15 branch August 16, 2022 08:49
jibeee added a commit that referenced this pull request Sep 26, 2022
@jibeee
Merge pull request #114 from LedgerHQ/pr110-review
1d96de2 
Review PR #110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selsta selsta selsta left review comments

@j-berman j-berman j-berman approved these changes

Assignees

@fbeutin-ledger fbeutin-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbeutin-ledger @selsta @j-berman