Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger support for hf 15 (BP+, view tags) [master] #8465

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

j-berman
Copy link
Collaborator

Pairs with: LedgerHQ/app-monero#110

I tested sending/receiving mainnet txs + tested sending/receiving testnet txs (post-fork), both exporting view key and not.

@j-berman j-berman changed the title ledger support for hf 15 (BP+, view tags) ledger support for hf 15 (BP+, view tags) [master] Jul 27, 2022
@selsta
Copy link
Collaborator

selsta commented Aug 3, 2022

Warning during compilation.

In file included from /Users/selsta/dev/monero/tests/unit_tests/device.cpp:32:
/Users/selsta/dev/monero/src/device/device_default.hpp:104:19: warning: 'derive_view_tag' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
            bool  derive_view_tag(const crypto::key_derivation &derivation, const std::size_t output_index, crypto::view_tag &view_tag);
                  ^
/Users/selsta/dev/monero/src/device/device.hpp:180:23: note: overridden virtual function is here
        virtual bool  derive_view_tag(const crypto::key_derivation &derivation, const std::size_t output_index, crypto::view_tag &view_tag) = 0;
                      ^
1 warning generated.

{
ASSERT_X(recv_len>=1, "Not enough data from device");
memmove(&view_tag.data, &this->buffer_recv[offset], 1);
recv_len -= 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add ++ after offset here, in case stuff gets added later after this and goes out of sync

@j-berman j-berman force-pushed the ledger-support-hf15 branch from ba7b5d5 to 04a1e28 Compare August 6, 2022 22:01
@luigi1111 luigi1111 merged commit ab63fbc into monero-project:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants