Fix view tag derivation

LedgerHQ · Jul 19, 2022 · bf19f81 · bf19f81
1 parent a4964ae
commit bf19f81
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/monero_crypto.c b/src/monero_crypto.c
@@ -527,7 +527,7 @@ void monero_derive_view_tag(unsigned char *view_tag, unsigned char *drv_data,
     unsigned char varint[8 + 32 + 8];
     unsigned int len_varint;
 
-    os_memmove(varint, "view_tag", 8);
+    os_memmove(varint, "view_tag", 8); // leave off null terminator
     os_memmove(varint + 8, drv_data, 32);
     len_varint = monero_encode_varint(varint + 8 + 32, 8, out_idx);
     len_varint += 8 + 32;

diff --git a/src/monero_key.c b/src/monero_key.c
@@ -614,7 +614,7 @@ int monero_apdu_derive_view_tag(
     unsigned char res[1];
 
     // fetch
-    monero_io_fetch_decrypt(derivation, 32, TYPE_DERIVATION);
+    monero_io_fetch(derivation, 32);
     output_index = monero_io_fetch_u32();
     monero_io_discard(0);