Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function to show players names #40

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Function to show players names #40

merged 2 commits into from
Apr 16, 2022

Conversation

DevonX
Copy link
Contributor

@DevonX DevonX commented Apr 14, 2022

Please review!

This is due to #23 and will show the players name in game.

If you spot anything, I am happy to see suggestions.

@DevonX DevonX added the enhancement New feature or request. This will increase MINOR version number, when merged into develop. label Apr 14, 2022
@DevonX DevonX requested review from shebpamm, Ismoh and willjallen April 14, 2022 15:05
@DevonX DevonX self-assigned this Apr 14, 2022
@DevonX DevonX linked an issue Apr 14, 2022 that may be closed by this pull request
Show players name in game #23
Closed
@Ismoh
Copy link
Owner

Ismoh commented Apr 14, 2022

Thanks a lot! I really appreciate your help and I am happy to see progress on this!

@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #40 (6fb39f0) into develop (6af3562) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #40   +/-   ##
========================================
  Coverage    47.95%   47.95%           
========================================
  Files           13       13           
  Lines         2711     2711           
========================================
  Hits          1300     1300           
  Misses        1411     1411
Flag Coverage Δ
unittesting 47.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af3562...6fb39f0. Read the comment docs.

@Ismoh
Copy link
Owner

Ismoh commented Apr 14, 2022

@shebpamm and @willjallen
It's the first PR with reviewers, feel free to take a look!
If this isn't merge after some days, I'll do manually, but would be awesome to see you having a look, thanks <3

@Ismoh
Copy link
Owner

Ismoh commented Apr 14, 2022

Codecov Report

Merging #40 (aedca82) into develop (6af3562) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #40   +/-   ##
========================================
  Coverage    47.95%   47.95%           
========================================
  Files           13       13           
  Lines         2711     2711           
========================================
  Hits          1300     1300           
  Misses        1411     1411

Flag Coverage Δ
unittesting 47.95% <ø> (ø)
Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af3562...aedca82. Read the comment docs.

@DevonX
If you are interested in unit testing, I can give you a quick introduction :)
Just let me know 👍

Ismoh
Ismoh approved these changes Apr 14, 2022
View reviewed changes
Copy link
Owner

@Ismoh Ismoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! This was my first review on NoitaMP.
Thank you very much!

@Ismoh
Copy link
Owner

Ismoh commented Apr 16, 2022

@shebpamm and @willjallen please review the PR.
If there any questions please give me a shout!
image

If you are not interested in reviewing PRs, please let me know!

@Ismoh Ismoh merged commit fbccb29 into develop Apr 16, 2022
@Ismoh Ismoh deleted the 23-show-players-name-in-game branch April 16, 2022 11:01
This was referenced Apr 16, 2022
Closed
Closed
This was referenced Sep 27, 2022
Merged
Merged
This was referenced Oct 6, 2022
Merged
Merged
@github-actions github-actions bot mentioned this pull request Oct 14, 2022
Merged
This was referenced Oct 27, 2022
Closed
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jan 9, 2023
Merged
This was referenced Jan 15, 2023
Merged
Closed
@github-actions github-actions bot mentioned this pull request Feb 17, 2023
Merged
@github-actions github-actions bot mentioned this pull request Mar 5, 2023
Merged
This was referenced Jun 30, 2023
Closed
Closed
Closed
Closed
Closed
Merged
Merged
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ismoh Ismoh Ismoh approved these changes

@shebpamm shebpamm Awaiting requested review from shebpamm

@willjallen willjallen Awaiting requested review from willjallen

Assignees

@DevonX DevonX

Labels
enhancement New feature or request. This will increase MINOR version number, when merged into develop.
Projects
NoitaMP
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show players name in game
2 participants
@DevonX @Ismoh