Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the reports/reporting nav items #4240

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Dec 4, 2024

Building off of the conversation had in #4051, this adds the navigation to the reporting table to be under the submitted reports view rather than being in the main nav bar

This makes things a little simpler and explicit for the user but I think this is a temp fix, with #4239 being a permanent solution

Test Steps

  • Ensure the reporting table is accessible via Reports in the nav menu -> View all reports in the heading

@wes-otf wes-otf requested a review from frjo December 4, 2024 15:13
@wes-otf wes-otf changed the title Combine the reports/reporting views Combine the reports/reporting nav items Dec 4, 2024
@frjo
Copy link
Member

frjo commented Dec 4, 2024

@wes-otf Good improvement I think.

If the current text links is to subtle we could use tabs instead. Maybe in the style we use for the Table/List view on the submission all view.

Copy link
Member

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my testing.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 5, 2024
@wes-otf
Copy link
Contributor Author

wes-otf commented Dec 6, 2024

Maybe in the style we use for the Table/List view on the submission all view.

@frjo I like this idea, would make everything seem more cohesive - potentially something to consider in #4329

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 6, 2024
@frjo frjo merged commit 35f1a43 into main Dec 6, 2024
7 checks passed
@theskumar theskumar deleted the ehancement/combine-reporting-views branch March 11, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants