Add a reporting table for projects #4051
Conversation
|
@frjo Is this one ready for merge? |
| verbose_name="Due Date", accessor="report_config__current_report__end_date" | ||
| ) | ||
| current_report_last_notified_date = tables.Column( | ||
| verbose_name="Last Notified", |
There was a problem hiding this comment.
Please avoid title case. We have it in several places but are moving away from it.
hypha/apply/projects/urls.py
Outdated
| @@ -39,6 +40,7 @@ | |||
| path("all/", ProjectListView.as_view(), name="all"), | |||
| path("statuses/", get_project_status_counts, name="projects_status_counts"), | |||
| path("invoices/", InvoiceListView.as_view(), name="invoices"), | |||
| path("reporting/", ReportingView.as_view(), name="reporting"), | |||
There was a problem hiding this comment.
Moving this down to "reports/" might look nicer.
|
This table is specifically for monitoring the status of reports. When projects get through the main phases and into the reporting phase, our client needed a way to manage, filter, and sort based on the status of those reports. So this adds a number of columns not on the original project table specifically having to do with whether reports are up to date, etc. We felt that this table should be separate, just for the user experience. There would be a number of new columns that would need to be prefixed with "Report " if we added them to the project table, rather than having a view into just the status of the various project reports. Furthermore, the project table might get a bit busy. |
What a small line for such a large set of changes. Those supporting changes include: * Creating a view for the new Reporting Table * Creating a current_report() method in report_config that is slightly differnt than current_report_due (see inline doc) * Adding a ProjectQuerySet method that does some intense subquerying to be able to express the current_report in sql so that the status can be filtered against Issue #4050
frjo
force-pushed
the
add-project-reporting-table
branch
from
4601029 to
2a3287c
Compare
frjo
added
Status: Needs testing
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
|
Works well! I might write up an issue to put this as a view under Reports thought so we don't have menu items for |
|
@wes-otf I agree that the two report items in the menu can be confusing. Please create a PR with your suggestion, sounds better. |
Building off of the conversation had in #4051, this adds the navigation to the reporting table to be under the submitted reports view rather than being in the main nav bar This makes things a little simpler and explicit for the user but I think this is a temp fix, with #4239 being a permanent solution
Fixes #4050
What a small line for such a large set of changes. Those supporting changes include:
Note from the cherry-picker/integrator
I see that the summary tables for reports was removed from
apply/projectsand that the current dropdown in the main navigation header points toapply/project/reports. This new table appears underapply/project/reportingand is linked to in the original fork in which this change occurred. As for integration here, the question is: do we want to replace the original table or augment off to the side somehow? Where should the link to this new table live?Test Steps
URL is
apply/projects/reporting.