Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated assigned comments & added more context #4329

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Jan 9, 2025

Fixes #4327. Adds a little more context to an assigned comment and will give a sample of the comment, truncating it if it goes over 2 lines.

Screenshots

The assigned comment in the comms tab
Screenshot 2025-01-09 at 11 41 44

The resulting tasks
Screenshot 2025-01-09 at 11 43 29

Test Steps

  • Ensure assigned comments are truncated in the My Tasks list and include the comment author/source project or application

@wes-otf wes-otf added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter labels Jan 9, 2025
@wes-otf wes-otf requested a review from frjo January 9, 2025 16:46
@wes-otf
Copy link
Contributor Author

wes-otf commented Jan 9, 2025

was hovering on the first task in the screenshot which is why the "X" is shown

@wes-otf wes-otf changed the title truncated assigned comments & added more information about the author… Truncated assigned comments & added more context Jan 9, 2025
@frjo
Copy link
Member

frjo commented Jan 9, 2025

Looks a lot better.

@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 9, 2025
@wes-otf
Copy link
Contributor Author

wes-otf commented Jan 9, 2025

worked good for me on test, I think it's ready if you do @frjo

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jan 9, 2025
@frjo frjo merged commit 4086c24 into main Jan 10, 2025
7 checks passed
@frjo frjo deleted the fix/assigned-comments-task-improvements branch March 11, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text of an assigned comment should be truncated and potentially include more details
2 participants