-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django 4.1.x #3398
Upgrade to Django 4.1.x #3398
Conversation
theskumar
commented
May 9, 2023
•
edited
Loading
edited
- Upgrade Django, wagtail-purge, Django-pwned-password,django-basic-auth-ip-whitelist
- Move logic from DeleteView -> delete() to form_valid()
- Make test more robust
- Upgrade dj-database-url to 2.x, and enable CONN_HEALTH_CHECKS
- Bump django-two-factor-auth to 1.15.x that has confirmed support for Django 4.1
- Bump django-ratelimit to 4.1.0
- django-pwned-passwords seems be abandoned Update to work with Django 4.0 jamiecounsell/django-pwned-passwords#11 (replaced with it with it's fork)
5fd18b9
to
d50dc8b
Compare
6220d85
to
62a8fb3
Compare
6959070
to
f90813b
Compare
99cc724
to
cba8067
Compare
Update: Rebased on |
@frjo Update with main and resolved conflicts. |
Test are failing, found this regarding
|
* origin/main: Bump @babel/traverse from 7.22.8 to 7.23.2 (#3619)
Updated the code. The logic behind the SuccessURLAllowedHostsMixin is was already covered in the get_redirect_url |
|
@theskumar I merge in a couple of you other update PRs so this one has a small merge conflict now. Will run this on test for a some days to be sure but it seems good to go in my testing. |
Thanks for the quick merging. I've resolve the conflicts with |
@theskumar Yes, I think it would be good to do the Wagtail 5 on top of Django 4. I think we can get this PR quickly tested and then merged in to main. For Django 4.2.x LTS we need Wagtail 5 I believe. But that where I would like to go before the end of the year. |
Done. Updated the base of the wagtail 5x to this PR. |
- Upgrade Django, wagtail-purge, Django-pwned-password,django-basic-auth-ip-whitelist - Move logic from DeleteView -> delete() to form_valid() - Make test more robust - Upgrade dj-database-url to 2.x, and enable CONN_HEALTH_CHECKS - Bump django-two-factor-auth to 1.15.x that has confirmed support for Django 4.1 - Bump django-ratelimit to 4.1.0 - django-pwned-passwords seems be abandoned jamiecounsell/django-pwned-passwords#11 (replaced with it with it's fork)
- Upgrade Django, wagtail-purge, Django-pwned-password,django-basic-auth-ip-whitelist - Move logic from DeleteView -> delete() to form_valid() - Make test more robust - Upgrade dj-database-url to 2.x, and enable CONN_HEALTH_CHECKS - Bump django-two-factor-auth to 1.15.x that has confirmed support for Django 4.1 - Bump django-ratelimit to 4.1.0 - django-pwned-passwords seems be abandoned jamiecounsell/django-pwned-passwords#11 (replaced with it with it's fork)