Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of stream form fields #3622

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix rendering of stream form fields #3622

merged 1 commit into from
Oct 20, 2023

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Oct 20, 2023

How to reproduce:

  • open a application submisssion with checkboxes as an form element.
  • Get the error below
'str' object has no attribute 'help_text'

Screenshot 2023-10-20 at 9  43 45@2x

How to reproduce:
- open a application submisssion with checkboxes as an form element.
- Get the error below

```
'str' object has no attribute 'help_text'
```
@theskumar theskumar self-assigned this Oct 20, 2023
@theskumar theskumar added Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter labels Oct 20, 2023
@frjo
Copy link
Member

frjo commented Oct 20, 2023

The bug activated when the checkboxes field are not set to multiple, i.e. it becomes radios.

This PR fixes it. Nice catch! Wonder how we miss it before, did nobody use radios?

@frjo frjo merged commit 88a7d69 into main Oct 20, 2023
theskumar added a commit that referenced this pull request Oct 23, 2023
* origin/main:
  Fix rendering of stream form fields (#3622)
  Upgrade development dependencies to latest (#3624)
  Update mkdocs version + update header color (#3623)
@theskumar theskumar deleted the fix/stream-field-rendering branch October 23, 2023 05:25
theskumar added a commit that referenced this pull request Oct 23, 2023
…login-signup

* origin/main:
  Remove depreciation warning for mkdocs material emoji support (#3626)
  Upgrade packages with patches/security updates (#3625)
  Fix rendering of stream form fields (#3622)
  Upgrade development dependencies to latest (#3624)
  Update mkdocs version + update header color (#3623)
  Bump @babel/traverse from 7.22.8 to 7.23.2 (#3619)
wes-otf pushed a commit that referenced this pull request May 7, 2024
How to reproduce:
- open a application submisssion with checkboxes as an form element.
- Get the error below

```
'str' object has no attribute 'help_text'
```
wes-otf pushed a commit that referenced this pull request May 8, 2024
How to reproduce:
- open a application submisssion with checkboxes as an form element.
- Get the error below

```
'str' object has no attribute 'help_text'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants