Custom applicant dashboard header #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsajan0
requested review from
theskumar and
frjo
and removed request for
theskumar
Can you share some info on it, it see it being fundamentally same. I agree the rest of the admin bar will update as a result of this, but it's that expected here? |
3 tasks
|
As per the latest designs, almost all the headings are centered except applicant dashboard. 
So, we can keep the admin bar component text-centered, and as it is just one place so can have a custom code like submission and project detail pages. |
frjo
added
Type: Enhancement
|
We should able to pass an extra parameter |
frjo
pushed a commit
that referenced
this pull request
Oct 16, 2023
Fixes #3588 Increase the font-weight on the heading in the admin bar. The application details and project detail doesn't use the admin bar so updated the font weight on it separately. The are other pages that doesn't still use admin-bar web component. They'll get the same treatment once admin-bar component is used in them. I'll try to convert more pages to use the admin-bar in this PR. - [x] Review edit page - [x] Review detail page - [x] Add Review page Related #3587
|
@sandeepsajan0 We have merged in everything on test now to main so this can be rebased. |
sandeepsajan0
force-pushed
the
enhancement/applicant-header
branch
from
60b3c09 to
65a1446
Compare
frjo
approved these changes
Oct 26, 2023
frjo
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
wes-otf
pushed a commit
that referenced
this pull request
May 7, 2024
Fixes #3588 Increase the font-weight on the heading in the admin bar. The application details and project detail doesn't use the admin bar so updated the font weight on it separately. The are other pages that doesn't still use admin-bar web component. They'll get the same treatment once admin-bar component is used in them. I'll try to convert more pages to use the admin-bar in this PR. - [x] Review edit page - [x] Review detail page - [x] Add Review page Related #3587
wes-otf
pushed a commit
that referenced
this pull request
May 7, 2024
Updated the applicant dashboard header as per the latest designs. Used a custom code instead of admin bar component because needed custom implementation that is different from other or common admin bars(headers)
wes-otf
pushed a commit
that referenced
this pull request
May 8, 2024
Fixes #3588 Increase the font-weight on the heading in the admin bar. The application details and project detail doesn't use the admin bar so updated the font weight on it separately. The are other pages that doesn't still use admin-bar web component. They'll get the same treatment once admin-bar component is used in them. I'll try to convert more pages to use the admin-bar in this PR. - [x] Review edit page - [x] Review detail page - [x] Add Review page Related #3587
wes-otf
pushed a commit
that referenced
this pull request
May 8, 2024
Updated the applicant dashboard header as per the latest designs. Used a custom code instead of admin bar component because needed custom implementation that is different from other or common admin bars(headers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the applicant dashboard header as per the latest designs.
Current version(old):
Updated version(latest):
Used a custom code instead of admin bar component because needed custom implementation that is different from other or common admin bars(headers)