Feature Request: Assign task to yourself #19515

tienifr · 2023-05-24T09:23:43Z

Details

This PR implements new feature that allow users to assign a task to themselves.

Fixed Issues

$ #19132
PROPOSAL: #19132 (comment)

Tests

Login with any account
====
Click FAB icon >> Assign task
Fill in Title and Description >> Next
Press Assignee
Verify that the Assign to me section is on top of the options list and includes the current user option
Select the current user
Press Confirm task
Verify that it requires selecting the Share destination
Press Share somewhere >> Select any contact
Press Confirm task
Verify the CreateTask API responds with jsonCode: 200
Verify that the task is successfully created in both Task report and parent report (the selected share destination)
====
Navigate to the newly create Task report
Press Mark as done
Verify that the CompleteTask API responds with jsonCode: 200
Verify that the task is successfully marked as done in both Task report and parent report
====
Navigate to the Task report
Press vertical three dots menu on report header >> Mark as incomplete
Verify that the ReopenTask API responds with jsonCode: 200
Verify that the task is successfully re-opened in both Task report and parent report
====
Navigate to the Task report
Press vertical three dots menu on report header >> Cancel
Verify that the CancelTask API responds with jsonCode: 200
Verify that the task is successfully canceled in both Task report (archived now) and parent report

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Login with any account
====
Click FAB icon >> Assign task
Fill in Title and Description >> Next
Press Assignee
Verify that the Assign to me section is on top of the options list and includes the current user option
Select the current user
Press Confirm task
Verify that it requires selecting the Share destination
Press Share somewhere >> Select any contact
Press Confirm task
Verify that the task is successfully created in both Task report and parent report (the selected share destination)
====
Navigate to the newly create Task report
Press Mark as done
Verify that the task is successfully marked as done in both Task report and parent report
====
Navigate to the Task report
Press vertical three dots menu on report header >> Mark as incomplete
Verify that the task is successfully re-opened in both Task report and parent report
====
Navigate to the Task report
Press vertical three dots menu on report header >> Cancel
Verify that the task is successfully canceled in both Task report (archived now) and parent report

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.27-05-2023.01.31.43.webm

Mobile Web - Chrome

Screenrecording_20230527_013456.mp4

Mobile Web - Safari

https://drive.google.com/file/d/1JePBXb81hbW231G_V2olZ1KwmUwXiPWf/view?usp=sharing

Desktop

https://drive.google.com/file/d/15dhA8QYbfs3vyChijK25jhnTy8nJb0Fy/view?usp=sharing

iOS

https://drive.google.com/file/d/1EY3wCnCaXB7Y8hDpuGz1rMBEOIoEJpQV/view?usp=sharing

Android

https://drive.google.com/file/d/1PHJp7T5RWpQbWTptBDICsjsEsHxcoygU/view?usp=sharing

melvin-bot · 2023-05-26T18:42:20Z

@thienlnam @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/languages/es.js

src/libs/actions/Task.js

Co-authored-by: Eugene Voloshchak <[email protected]>

src/libs/actions/Task.js

eVoloshchak · 2023-05-29T20:25:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-30.at.12.46.48.mov

Mobile Web - Chrome

Screen_Recording_20230530-131051_Chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-05-30.at.13.19.01.mov

Desktop

Screen.Recording.2023-05-30.at.13.32.17.mov

iOS

Screen.Recording.2023-05-30.at.13.16.02.mov

Android

screen-20230530-132730.mp4

eVoloshchak · 2023-05-30T16:27:25Z

@tienifr, could you take a look at PR Author Checklist failing?

tienifr · 2023-05-30T16:30:02Z

@eVoloshchak done

eVoloshchak

Looks good to me
cc: @thienlnam

thienlnam · 2023-06-01T21:24:41Z

@shawnborton What do you think this should look like in the assignee selector when you can select yourself? Right now it's shown as another section 'Assign to me'

shawnborton · 2023-06-05T07:11:07Z

I think that works? What do you think?

thienlnam · 2023-06-05T13:29:29Z

Yup, works for me as well!

OSBotify · 2023-06-05T13:36:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-05T19:25:08Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-07T03:28:58Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-07T13:20:37Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

aldo-expensify · 2023-06-19T23:46:57Z

src/libs/OptionsListUtils.js

+    let currentUserOption = _.find(allPersonalDetailsOptions, (personalDetailsOption) => personalDetailsOption.login === currentUserLogin);
+    if (searchValue && !isSearchStringMatch(searchValue, currentUserOption.searchText)) {
+        currentUserOption = null;
+    }


Seems like it may be possible to not find currentUserLogin within the allPersonalDetailsOptions, or at least it is happening to me in dev:

Any key I type in the search just crashes

Selectors were likely broken with the privacy changes to use accountIDs

tienifr added 3 commits May 24, 2023 16:22

feature: assign task to yourself

91ed300

share destination is required

3cf9de3

fix lint

7fd30ee

tienifr marked this pull request as ready for review May 26, 2023 18:42

tienifr requested a review from a team as a code owner May 26, 2023 18:42

melvin-bot bot requested review from eVoloshchak and removed request for a team May 26, 2023 18:42

melvin-bot bot requested a review from thienlnam May 26, 2023 18:42

eVoloshchak suggested changes May 29, 2023

View reviewed changes

src/languages/es.js Outdated Show resolved Hide resolved

src/libs/actions/Task.js Show resolved Hide resolved

Update src/libs/actions/Task.js

ed95ae8

Co-authored-by: Eugene Voloshchak <[email protected]>

eVoloshchak reviewed May 29, 2023

View reviewed changes

src/libs/actions/Task.js Outdated Show resolved Hide resolved

refactor

55f3d06

add es translation

bb0f05d

eVoloshchak approved these changes May 30, 2023

View reviewed changes

thienlnam mentioned this pull request Jun 1, 2023

[PAID] [$1000] Allow assigning yourself to a task #19132

Closed

6 tasks

thienlnam approved these changes Jun 5, 2023

View reviewed changes

thienlnam merged commit 8bf3cbe into Expensify:main Jun 5, 2023

OSBotify mentioned this pull request Jun 5, 2023

Deploy Checklist: New Expensify 2023-06-05 #20195

Closed

51 tasks

This was referenced Jun 6, 2023

[$1000] Web - Task - Task actions not updated in real time in task report #20266

Closed

Assign task - Error message about title shows up when title is inputted #20281

Closed

[HOLD 19330] Assign task - Mark as complete CTA is cut off #20284

Closed

kbecciv mentioned this pull request Jun 6, 2023

Task - Task is not unchecked when marked as incomplete #20285

Closed

6 tasks

isagoico mentioned this pull request Jun 6, 2023

[$1000] Create task - Share Somewhere - Unable to select a user that doesn't have a existing conversation #20305

Closed

6 tasks

marcaaron mentioned this pull request Jun 19, 2023

Split bill - Can't select more than few users under specific Gmail account login #21002

Closed

6 tasks

aldo-expensify reviewed Jun 19, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature Request: Assign task to yourself #19515

Feature Request: Assign task to yourself #19515

tienifr commented May 24, 2023 •

edited

Loading

melvin-bot bot commented May 26, 2023

eVoloshchak commented May 29, 2023 •

edited

Loading

eVoloshchak commented May 30, 2023

tienifr commented May 30, 2023

eVoloshchak left a comment

thienlnam commented Jun 1, 2023

shawnborton commented Jun 5, 2023

thienlnam commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

aldo-expensify Jun 19, 2023

aldo-expensify Jun 19, 2023

thienlnam Jun 21, 2023

Feature Request: Assign task to yourself #19515

Feature Request: Assign task to yourself #19515

Conversation

tienifr commented May 24, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 26, 2023

eVoloshchak commented May 29, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak commented May 30, 2023

tienifr commented May 30, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

thienlnam commented Jun 1, 2023

shawnborton commented Jun 5, 2023

thienlnam commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

aldo-expensify Jun 19, 2023

Choose a reason for hiding this comment

aldo-expensify Jun 19, 2023

Choose a reason for hiding this comment

thienlnam Jun 21, 2023

Choose a reason for hiding this comment

tienifr commented May 24, 2023 •

edited

Loading

eVoloshchak commented May 29, 2023 •

edited

Loading