Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 19330] Assign task - Mark as complete CTA is cut off #20284

Closed
2 of 6 tasks
kbecciv opened this issue Jun 6, 2023 · 8 comments
Closed
2 of 6 tasks

[HOLD 19330] Assign task - Mark as complete CTA is cut off #20284

kbecciv opened this issue Jun 6, 2023 · 8 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jun 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #19515

Action Performed:

  1. Launch New Expensify app.
  2. Tap + > Assign task.
  3. Enter title and description > Next.
  4. Select current user as assignee and share destination.
  5. Tap Confirm task.
  6. Open parent report

Expected Result:

Mark as complete CTA is not cut off.

Actual Result:

Mark as complete CTA is partially cut off.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6082409_Screen_Recording_20230607_001340_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 6, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Jun 6, 2023
@thienlnam
Copy link
Contributor

This is not a blocker, and also exists on production @kbecciv
I noticed that both
#20281 and this issue say that the issue is not reproducible on production but that is not true, I've been able to quickly reproduce both of them in production

Screenshot 2023-06-06 at 1 52 29 PM Screenshot 2023-06-06 at 1 52 49 PM

@thienlnam
Copy link
Contributor

thienlnam commented Jun 6, 2023

Leaving this issue open so we can keep track of it, but we are fixing it in #19330 since we're going to redesign the page

@thienlnam thienlnam added Weekly KSv2 and removed Hourly KSv2 labels Jun 6, 2023
@thienlnam thienlnam assigned thienlnam and unassigned srikarparsi Jun 6, 2023
@thienlnam thienlnam changed the title Assign task - Mark as complete CTA is cut off [HOLD 19330] Assign task - Mark as complete CTA is cut off Jun 6, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 14, 2023
@thienlnam
Copy link
Contributor

Same as above, Jasper is working on the redesign

@melvin-bot melvin-bot bot removed the Overdue label Jun 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 23, 2023
@thienlnam
Copy link
Contributor

Same as above!

@melvin-bot melvin-bot bot removed the Overdue label Jun 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2023
@thienlnam
Copy link
Contributor

Same, above should get merged soon

@melvin-bot melvin-bot bot removed the Overdue label Jul 6, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 14, 2023
@thienlnam
Copy link
Contributor

We're good here!

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants