Split bill - Can't select more than few users under specific Gmail account login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login with Gmail account with a lot of chats (always reproduced with [email protected]
2. Try to Split bill with 8 users

Expected Result:

The user should be able to select Split bill users without any issues

Actual Result:

As soon as a few users are selected - all the others disappear, the search also does not work.
Only for specific Gmail accounts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6097942_Split_-_Web.mp4

1111.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dylanexpensify]

@marcaaron I believe you're on today, is that right?

[marcaaron]

Yes looking 👀

[marcaaron]

Yikes this flow seems super broken...

[marcaaron]

Crashing here:

App/src/libs/OptionsListUtils.js

Lines 745 to 748 in f1b37bb

	if (searchValue && !isSearchStringMatch(searchValue, currentUserOption.searchText)) {
	currentUserOption = null;
	}

Last touched here:

#19515

possibly related to this one: https://github.com/Expensify/App/pull/20371/files

Still looking...

[marcaaron]

Fix incoming. I think we will maybe want to look into fixing this in Web-E based on the conversation here: https://expensify.slack.com/archives/C07J32337/p1687199748385919?thread_ts=1687190209.326479&cid=C07J32337 cc @Beamanator

[marcaaron]

After the crash is fixed there is an issue related to duplicate accounts showing up. Caused by report options and personal details options not having login fields at all here:

App/src/libs/OptionsListUtils.js

Lines 730 to 734 in 55e3cb9

	// Next loop over all personal details removing any that are selectedUsers or recentChats
	_.each(allPersonalDetailsOptions, (personalDetailOption) => {
	if (_.some(loginOptionsToExclude, (loginOptionToExclude) => loginOptionToExclude.login === personalDetailOption.login)) {
	return;
	}

I am going to presume it's because we removed them in Auth/Web-Expensify without first migrating the App code, but will continue to help investigate tomorrow if required!

@Beamanator @puneetlath I think whatever we did in Auth/Web is really a "web deploy blocker" in that once it goes to production it will break the current App because the code expects login to exist on all these options. I tested this issue on staging app + production web and it doesn't exist there.

Probably a safer rollout would be to update the App code to work for all cases then introduce changes in Auth and Web-Expensify.

[aldo-expensify]

I'm also seeing the crashes in dev, and my own account multiple times in the result list when searching for a chat.

[luacmartins]

This is still a bug, but I'm removing the blocker label as per this comment.

[marcaaron]

@lanitochka17 can we get a retest on this one? I think it's been fixed maybe?

[youssef-lr]

This seems to have been fixed, I can't reproduce it on staging.

[lanitochka17]

@marcaaron Hello, still reproducible, in search dialog a lot of old chats, but in Split bill - no. Checked with [email protected] “problematic” account

Screen.Recording.2023-06-21.at.14.31.26.2.mov

[marcaaron]

Can you sign out and sign back in to see if the issue persists? I am suspecting this is due to some bad data stored.