Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2025-02-12 #56710

Closed
33 tasks done
github-actions bot opened this issue Feb 12, 2025 · 11 comments
Closed
33 tasks done

Deploy Checklist: New Expensify 2025-02-12 #56710

github-actions bot opened this issue Feb 12, 2025 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Release Version: 9.0.97-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@m-natarajan m-natarajan added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 12, 2025
@izarutskaya
Copy link

izarutskaya commented Feb 12, 2025

Regression is at 87% completed.

Unchecked PRs:
#56401 - failing on iOS. Android apps #56401 (comment) Pending validation on Web, mWeb and Desktop
#55438 - found issue on mWeb #55438 (comment) Pending validation on iOS

DB:
#56719
#56729

@adhorodyski
Copy link
Contributor

Cross-posted deploy blockers with the Callstack team to help out!

@gleitebr gleitebr added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Feb 12, 2025
@m-natarajan
Copy link

Regression is 3% left

Unchecked PRs:
#55384 failing with #56752, bug is reproduced in production, checking it off
#56401 - failing on iOS. Android apps #56401 (comment) Pending validation on Web, mWeb and Desktop
#55438 - found issue on mWeb #55438 (comment) and failing on iOS with known issue Failing with #55438 (comment) on iOS app
#56364 (comment)
#56401 failing with #56719 and PR is reverted #56744, can we check it off?
#56513 failing on android and iOS with known issue #55114

Open blockers:
#56719
#56751
#56754

@m-natarajan
Copy link

m-natarajan commented Feb 12, 2025

Regression is completed

Unchecked PRs:
#56401 - failing on iOS. Android apps #56401 (comment) Pending validation on Web, mWeb and Desktop
#55438 - found issue on mWeb #55438 (comment) and failing on iOS with known issue Failing with #55438 (comment) on iOS app
#56364 (comment)
#56401 failing with #56719 and PR is reverted #56744, can we check it off?
#56513 failing on android and iOS with known issue #55114

Open blockers:
#56719
#56751
#56754
#56758

These critical issues are blocking our test cases:
#48378 - Sign in – Unable to login via Magic link, Magic code expired appears
#48597 - Expensify Card - Payment error occurs when trying to pay by card via PayPal
#55771 - Hybrid app - Sign In - unable to create a new expensifail account
#51090 - Deeplinking opens mWeb or NewDot stg app but not the Hybrid app

@Julesssss
Copy link
Contributor

Hi @m-natarajan, thanks. I shared here, but I think 3 or 4 blockers should be resolved with build 9.0.97-1.

@Julesssss
Copy link
Contributor

CHecked off some issues with known existing problems that aren't blockers

@Julesssss
Copy link
Contributor

I am checking off #56364 as the feature is under a beta.

@Julesssss
Copy link
Contributor

  • Github UP
  • App timing nominal

@Julesssss
Copy link
Contributor

Android:

  • This SingleTimeAndDatePicker crash is continuing to spike and needs investigation. It won't block deploy though as it's already released to 100% of users in 9.0.94.24
    • I created an issue here and shared with SWM to be picked up tomorrow morning

iOS

  • Still trending down
  • One exception is this yaplAddReceiptsEmailAddress crash, but is from 9.0.95.6, has 9 occurances, and is released to 100%. Will investigate tomorrow if it wasn't a one off.

@Julesssss
Copy link
Contributor

:shipit:

@Julesssss Julesssss self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants