Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android hybrid - After completing the Plaid flow, standalone ND opens on Google Play store #56719

Closed
1 of 8 tasks
mitarachim opened this issue Feb 12, 2025 · 21 comments · Fixed by #56744
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.97-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #56401
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Workspace Settings

Action Performed:

  1. Launch hybrid app.
  2. Go to workspace settings > Workflows.
  3. Tap Connect bank account.
  4. Tap Log into your bank.
  5. Select Wells Fargo.
  6. Go through Plaid flow on the browser.

Expected Result:

After completing the Plaid flow, it will land in the app.

Actual Result:

After completing the Plaid flow, standalone ND opens on Google Play store

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6740220_1739328806640.1739328615247_56401_Android.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 12, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering and removed Daily KSv2 labels Feb 12, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added the Hourly KSv2 label Feb 12, 2025
@mitarachim
Copy link
Author

issue not repro in STG with use staging server OFF .
issue repro in STG with use staging server ON .

@mountiny
Copy link
Contributor

Testing revert of the getEnviroment PR here #56744 kicked off adhoc build @mitarachim can you please chekc on the build once ready?

issue not repro in STG with use staging server OFF .

I think you cannot user production API for this same as why you cannot connect in production app

@mitarachim
Copy link
Author

@mountiny noted , let me know once the build ready to use , thank you

@jnowakow
Copy link
Contributor

I tested it on adhoc build and I'm getting the same effect @mountiny

@techievivek
Copy link
Contributor

Interesting, so it means that the issue existed beforehand?

@jnowakow
Copy link
Contributor

I think earlier it was reproducible on adhoc builds and not on staging. On staging environment was set to production so I think the url passed to Plaid was different

@jnowakow
Copy link
Contributor

Especially since it's not reproducible when use staging server is OFF

@stitesExpensify
Copy link
Contributor

I am confident that this change is not related to the current web-expensify and web-secure code on staging.

@stitesExpensify stitesExpensify removed the DeployBlocker Indicates it should block deploying the API label Feb 12, 2025
@staszekscp
Copy link
Contributor

I've discussed the issue with @jnowakow. Actually, is it possible that there is a wrong package name configured on the Plaid account? I've looked at the documentation, and it says that the redirect on Android is based on the package name, not URL - maybe there is something wrong there? https://plaid.com/docs/link/oauth/#android-sdk-react-native-android

@Julesssss
Copy link
Contributor

Good shout. I'm checking internally for any Plaid console changes. @mountiny I agree with that PR being the likely candidate.

With it being a minor change perhaps I will merge the revert and CP to test it out.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Feb 12, 2025
@Julesssss
Copy link
Contributor

Julesssss commented Feb 12, 2025

Potentially related customer issue: https://expensify.slack.com/archives/CAS1DND4H/p1739302676966999

@Julesssss
Copy link
Contributor

I am confident that this change is not related to the current web-expensify and web-secure code on staging.

@stitesExpensify I'm not so sure. With these reports it's potentially backend (perhaps from Tuesday's deploy)

@m-natarajan
Copy link

We see this #52199 bug now

Screenrecorder-2025-02-12-22-56-06-633.mp4

@Julesssss
Copy link
Contributor

We see this #52199 bug now

Thanks, that is expected because we reverted the code for that fix.

@Julesssss
Copy link
Contributor

@m-natarajan to confirm, the bug within this issue is no longer occuring?

@Julesssss Julesssss reopened this Feb 12, 2025
@jnowakow
Copy link
Contributor

I think it wasn't caused by my changes from #56401 but by the code that is currently on main. Package passed to Plaid is always com.expensify.chat so after successful flow Plaid redirects to google play in order to install production ND. I think that the fix for the issue is to pass actual app id.
Currently I'm blocked by Plaid so I'm not able to confirm this but it seems reasonable.

@jnowakow
Copy link
Contributor

BTW on dev environment backend returns Plaid's production link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants