[No QA] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks) #56239

JKobrynski · 2025-02-03T15:08:25Z

Explanation of Change

Added an optional shouldRenderActionButtons param to tooltips as well as the UI logic that displays the new buttons.

Fixed Issues

$ #55007
PROPOSAL: N/A

Tests

Prerequisites

As of now there are no tooltips that display these new buttons, and this PR's sole purpose is to introduce the logic to display them, not to add the new tooltips. So, in order to see the buttons in the app, you have to modify the code slightly:

ReportActionCompose.tsx

- shouldRender={shouldShowProductTrainingTooltip}
+ shouldRender

This code will render the WORKSPACE_CHAT_CREATE tooltip even if you are not on a fresh account

TOOLTIPS.ts

    [WORKSAPCE_CHAT_CREATE]: {
        content: [
            {text: 'productTrainingTooltip.workspaceChatCreate.part1', isBold: false},
            {text: 'productTrainingTooltip.workspaceChatCreate.part2', isBold: true},
            {text: 'productTrainingTooltip.workspaceChatCreate.part3', isBold: false},
        ],
        onHideTooltip: () => dismissProductTraining(WORKSAPCE_CHAT_CREATE),
        name: WORKSAPCE_CHAT_CREATE,
        priority: 1100,
        shouldShow: () => true,
+       shouldRenderActionButtons: true,
    },

This code will render the new buttons in the WORKSPACE_CHAT_CREATE tooltip

Log into the app
Navigate to any chat
Make sure you can see the tooltip next to composer (if not, make sure you check Prerequisites above)
Check if you can also see the new buttons (Try it out and No thanks)

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

This is a No QA issue as it requires code modifications.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-02-03T15:52:16Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-02-04T08:19:50Z

src/languages/es.ts

@@ -6251,6 +6251,8 @@ const translations = {
            part6: 'Ahora,',
            part7: ' envía tu gasto y',
            part8: ' ¡observa cómo ocurre la magia!',
+            tryItOut: 'Prueba esto',


@JKobrynski Did we confirm this translation?

I asked for a confirmation here but got no replies, I used JaimeGPT to translate it

DylanDylann · 2025-02-04T08:36:25Z

src/components/ProductTrainingContext/TOOLTIPS.ts

@@ -129,6 +130,7 @@ const TOOLTIPS: Record<ProductTrainingTooltipName, TooltipData> = {
        name: SCAN_TEST_TOOLTIP,
        priority: 900,
        shouldShow: () => false,
+        shouldRenderActionButtons: true,


@JKobrynski I think we need to add shouldRenderActionButtons to WORKSAPCE_CHAT_CREATE tooltip instead of this place

I can change that if you want, but the purpose of this PR is just to allow us to display the action buttons, the actual logic for the new tooltip flow will be introduced later! Wdyt? Should we make that change?

@JKobrynski But currently it doesn't match your test step

Make sure you can see the tooltip next to composer (if not, make sure you check Prerequisites above)

Check if you can also see the new buttons (Try it out and No thanks)

If I change this, all users that sign up to a new account will see these buttons that will do nothing because the functionality is not implemented yet. In the ** Prerequisites** section I instructed reviewers to enable this for WORKSAPCE_CHAT_CREATE so they can see it on their own machine and verify if it looks right. We don't want to permanently change it, it's just for testing purposes.

DylanDylann · 2025-02-04T08:42:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…07-update-educational-tooltip

JKobrynski · 2025-02-10T14:26:56Z

@mountiny do you think we could merge this?

grgia · 2025-02-10T16:10:32Z

Taking a look at this!

grgia

Code LGTM, should we do a design review on screenshots now, or wait until we go live?

grgia · 2025-02-10T16:11:41Z

src/components/ProductTrainingContext/index.tsx

-                    })}
-                </Text>
+            <View>
+                <View style={[styles.alignItemsCenter, styles.flexRow, styles.justifyContentCenter, styles.flexWrap, styles.textAlignCenter, styles.gap3, styles.p2]}>


Let's get a design review before we merge this- I'm thinking we can just use screenshots since we can't adhoc build this rn?

I take it back, let's wait on the adhoc when we go live instead so we don't need duplicate reviews

OSBotify · 2025-02-11T12:23:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-12T02:07:27Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.97-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-12T22:06:57Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.97-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

add an option to display action buttons in tooltips

df566ce

JKobrynski changed the title ~~[Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks)~~ [No QA] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks) Feb 3, 2025

JKobrynski marked this pull request as ready for review February 3, 2025 15:52

JKobrynski requested a review from a team as a code owner February 3, 2025 15:52

melvin-bot bot requested review from DylanDylann and removed request for a team February 3, 2025 15:52

JKobrynski mentioned this pull request Feb 3, 2025

[Due for payment 2025-02-19] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks) #55007

Open

DylanDylann reviewed Feb 4, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into JKobrynski/feat/550…

175879f

…07-update-educational-tooltip

JKobrynski requested a review from DylanDylann February 6, 2025 15:40

DylanDylann approved these changes Feb 6, 2025

View reviewed changes

melvin-bot bot requested a review from grgia February 6, 2025 16:06

grgia approved these changes Feb 11, 2025

View reviewed changes

grgia merged commit b488416 into Expensify:main Feb 11, 2025
19 of 21 checks passed

github-actions bot mentioned this pull request Feb 12, 2025

Deploy Checklist: New Expensify 2025-02-12 #56710

Closed

33 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks) #56239

[No QA] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks) #56239

JKobrynski commented Feb 3, 2025 •

edited

Loading

melvin-bot bot commented Feb 3, 2025

DylanDylann Feb 4, 2025

JKobrynski Feb 5, 2025

DylanDylann Feb 4, 2025

JKobrynski Feb 5, 2025

DylanDylann Feb 5, 2025

JKobrynski Feb 6, 2025

DylanDylann commented Feb 4, 2025 •

edited

Loading

JKobrynski commented Feb 10, 2025

grgia commented Feb 10, 2025

grgia left a comment

grgia Feb 10, 2025

grgia Feb 11, 2025

OSBotify commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

[No QA] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks) #56239

[No QA] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks) #56239

Conversation

JKobrynski commented Feb 3, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann commented Feb 4, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

JKobrynski commented Feb 10, 2025

grgia commented Feb 10, 2025

grgia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

JKobrynski commented Feb 3, 2025 •

edited

Loading

DylanDylann commented Feb 4, 2025 •

edited

Loading