Create leave workspace functionality #56316

huult · 2025-02-04T10:28:09Z

Details

Fixed Issues

$ #55462
PROPOSAL: #55462 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Get invited to a random workspace as a member.
Navigate to Workspace → Settings.
Verify that you can remove yourself from the invited workspace.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-04.at.17.17.03.mp4

Android: mWeb Chrome

Screen.Recording.2025-02-04.at.17.18.37.mp4

iOS: Native

Screen.Recording.2025-02-04.at.17.19.59.mp4

iOS: mWeb Safari

Screen.Recording.2025-02-04.at.17.20.59.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-02-04.at.17.21.33.mp4

MacOS: Desktop

Screen.Recording.2025-02-04.at.17.22.53.mp4

melvin-bot · 2025-02-04T10:28:14Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-02-04T15:58:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-04.at.9.21.52.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-02-04.at.7.53.25.PM.mov

iOS: Native

Screen.Recording.2025-02-04.at.8.06.44.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-02-04.at.7.47.16.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-04.at.7.44.33.PM.mov

MacOS: Desktop

Screen.Recording.2025-02-04.at.7.56.52.PM.mov

src/languages/es.ts

…invited-workspace

huult · 2025-02-11T04:37:50Z

@shubham1206agra “ have finished updating the translation for leaving the workspace. Could you check this PR? Thanks!

dangrous

LGTM!

OSBotify · 2025-02-11T18:58:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

trjExpensify · 2025-02-11T23:04:53Z

@dangrous Actually I want to keep this separate since this issue only implements the button and #43508 implements the additional conditions to leave the room.

I don't understand that sentiment.

Did we just introduce a Leave button that when clicked, doesn't or shouldn't work for a bunch of people due to restrictions on leaving a workspace under certain conditions enforced on the backend? 🤔

dangrous · 2025-02-12T01:01:37Z

Looking back at this - I believe it will work fine for those who can use it, and will not work for those who should not be able to leave a workspace (prohibited on the backend). However, we should probably update to just not show the button for those folks. Apologies, I thought from the conversation on the other issue that it would be backend, which I don't have time for at the moment, but I'm not sure that's true - I think these are both frontend?

Maybe we can get a follow up going shortly.

github-actions · 2025-02-12T02:07:30Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.97-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

trjExpensify · 2025-02-12T09:19:36Z

I believe it will work fine for those who can use it, and will not work for those who should not be able to leave a workspace (prohibited on the backend).

It would have been great if someone tested that, it doesn't work fine. Here's one example. This is an approver who has an outstanding processing report submitted to them. As per the BE logic for leaving a workspace, they shouldn't be allowed to leave the workspace. In NewDot we're showing them a Leave button, they click it and it appears as though they've left the workspace successfully, but in reality they haven't.

2025-02-12_08-48-41.mp4

I still maintain we should not have pushed this PR separately without the appropriate handling on restrictions to leave/remove someone from the workspace as we've pointed to numerous times at this point.

Additionally, I don't think the new copy added in this PR is accurate as I mentioned here. You don't lose access to "all data associated with the workspace" upon leaving per se -- for example your expense reports remain shared with you. OldDot shows this today for a non-owner admin leaving a workspace:

Let's revert this PR, and tackle this once, consistently, and holistically.

CC: @MonilBhavsar

shubham1206agra · 2025-02-12T09:22:41Z

@trjExpensify Assign me and @huult #43508 and we can start working on this holistically. What do you think about this?

@huult In the meantime, let's prepare another PR for the same.

huult · 2025-02-12T09:33:31Z

sure

trjExpensify · 2025-02-12T09:43:02Z

Yeah, I think it's best if I create a fresh issue and assign everyone involved, then close #43508 & #55462 in favour of that.

I still think this PR should be reverted and not go to prod in the meantime.

mountiny · 2025-02-12T10:16:22Z

@shubham1206agra @huult can you create revert with [CP Staging] prefix please?

trjExpensify · 2025-02-12T10:59:35Z

Here's the fresh issue to tackle this holistically: #56750

huult · 2025-02-12T11:12:42Z

@shubham1206agra @huult can you create revert with [CP Staging] prefix please?

@shubham1206agra Will you do it, or should I do it?

shubham1206agra · 2025-02-12T12:13:11Z

@huult Please do the revert.

…ave-invited-workspace" This reverts commit 6999bfb, reversing changes made to 4bc37d7.

trjExpensify · 2025-02-12T20:04:16Z

Have we got this revert PR up? CC: @dangrous

github-actions · 2025-02-12T22:07:00Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.97-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

* main: (544 commits) Update Mobile-Expensify submodule version to 9.0.98-1 Update version to 9.0.98-1 Update Mobile-Expensify submodule version to 9.0.98-0 Update version to 9.0.98-0 update comment. Skip late check if the client is offline Clear intervals instead of skipping initialization Stopping logging missed PONGs if a PONG has already been missed fix unit test. Update Mobile-Expensify submodule version to 9.0.97-1 Update version to 9.0.97-1 Use correct approach for changing fn names Fix a few more lint things Fix default imports on tag settings apge Fix import spacing and order Remove default imports from category settings page Revert PR #56316 Revert PR #56316 match pattern Revert "Remove hybrid app check from getEnvironment" ...

Create leave workspace functionality

450c13b

huult requested a review from a team as a code owner February 4, 2025 10:28

melvin-bot bot requested a review from shubham1206agra February 4, 2025 10:28

melvin-bot bot removed the request for review from a team February 4, 2025 10:28

shubham1206agra reviewed Feb 4, 2025

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

huult added 3 commits February 5, 2025 09:57

Merge remote-tracking branch 'upstream/main' into 55462-unable-leave-…

2b607a0

…invited-workspace

Merge remote-tracking branch 'upstream/main' into 55462-unable-leave-…

a25c0d2

…invited-workspace

update translation for leaving workspace

7c9919a

shubham1206agra approved these changes Feb 11, 2025

View reviewed changes

melvin-bot bot requested a review from dangrous February 11, 2025 06:45

dangrous approved these changes Feb 11, 2025

View reviewed changes

dangrous merged commit 6999bfb into Expensify:main Feb 11, 2025
17 checks passed

github-actions bot mentioned this pull request Feb 12, 2025

Deploy Checklist: New Expensify 2025-02-12 #56710

Closed

33 tasks

trjExpensify mentioned this pull request Feb 12, 2025

[Simple AA in NewDot] No option to leave workspace as non-owner #43508

Closed

6 tasks

huult added a commit to huult/App that referenced this pull request Feb 12, 2025

Revert "Merge pull request Expensify#56316 from huult/55462-unable-le…

c83b464

…ave-invited-workspace" This reverts commit 6999bfb, reversing changes made to 4bc37d7.

huult added a commit to huult/App that referenced this pull request Feb 12, 2025

Revert PR Expensify#56316

39eb9c1

huult added a commit to huult/App that referenced this pull request Feb 12, 2025

Revert PR Expensify#56316

e754b44

melvin-bot bot mentioned this pull request Feb 12, 2025

[Due for payment 2025-02-25] [Due for payment 2025-02-19] [$250] Unable to leave a random workspace invited to #55462

Closed

8 tasks

This was referenced Feb 19, 2025

Implement the proper handling of restrictions to leave or be removed from a workspace in NewDot #56750

Open

[$250] Workspace - No confirmation modal when leaving workspace from workspace list #56722

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create leave workspace functionality #56316

Create leave workspace functionality #56316

huult commented Feb 4, 2025

melvin-bot bot commented Feb 4, 2025

shubham1206agra commented Feb 4, 2025

huult commented Feb 11, 2025

dangrous left a comment

OSBotify commented Feb 11, 2025

trjExpensify commented Feb 11, 2025

dangrous commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

trjExpensify commented Feb 12, 2025 •

edited

Loading

shubham1206agra commented Feb 12, 2025

huult commented Feb 12, 2025

trjExpensify commented Feb 12, 2025

mountiny commented Feb 12, 2025

trjExpensify commented Feb 12, 2025

huult commented Feb 12, 2025

shubham1206agra commented Feb 12, 2025

trjExpensify commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

Create leave workspace functionality #56316

Create leave workspace functionality #56316

Conversation

huult commented Feb 4, 2025

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 4, 2025

shubham1206agra commented Feb 4, 2025

Reviewer Checklist

Screenshots/Videos

huult commented Feb 11, 2025

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 11, 2025

trjExpensify commented Feb 11, 2025

dangrous commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

trjExpensify commented Feb 12, 2025 • edited Loading

shubham1206agra commented Feb 12, 2025

huult commented Feb 12, 2025

trjExpensify commented Feb 12, 2025

mountiny commented Feb 12, 2025

trjExpensify commented Feb 12, 2025

huult commented Feb 12, 2025

shubham1206agra commented Feb 12, 2025

trjExpensify commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

trjExpensify commented Feb 12, 2025 •

edited

Loading