Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Wallet - Prior bank account detail inputs are not shown. #54740

Closed
4 of 8 tasks
IuliiaHerets opened this issue Jan 2, 2025 · 18 comments
Closed
4 of 8 tasks

[$250] Wallet - Prior bank account detail inputs are not shown. #54740

IuliiaHerets opened this issue Jan 2, 2025 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 2, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.80-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: User Settings

Action Performed:

  1. Login to NewDot.
  2. Go to Settings > Wallet > Add bank account.
  3. Click Add bank account.
  4. Select any county other than United States(or select India)
  5. Click Next.
  6. Enter an account number matching Corpay’s requirements.
  7. Enter an IFSC code matching Corpay’s requirements.
  8. Click " < " to go back
  9. Click Next

Expected Result:

You land back on the bank account details page with all your prior inputs shown.

Actual Result:

You land back on the bank account details page with empty fields

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704929_1735788515638.Screen_Recording_2025-01-02_at_6.15.42_in_the_morning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021875146950762828799
  • Upwork Job ID: 1875146950762828799
  • Last Price Increase: 2025-01-10
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 2, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 2, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Beamanator
Copy link
Contributor

Beamanator commented Jan 2, 2025

Agreed in slack this should not be a blocker

@Gonals Gonals added the External Added to denote the issue can be worked on by a contributor label Jan 3, 2025
@melvin-bot melvin-bot bot changed the title Wallet - Prior bank account detail inputs are not shown. [$250] Wallet - Prior bank account detail inputs are not shown. Jan 3, 2025
Copy link

melvin-bot bot commented Jan 3, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021875146950762828799

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 3, 2025
Copy link

melvin-bot bot commented Jan 3, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

@LorenzoBloedow
Copy link

Proposal

Please re-state the problem that we are trying to solve in this issue.

Draft bank account data is not being completely saved when navigating back.

What is the root cause of that problem?

There's missing values not being saved in the fetchCorpayFields function in the src/libs/actions/BankAccounts.ts file.

What changes do you think we should make in order to solve the problem?

I think all draft data should be saved in the fetchCorpayFields function.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

There should be a test case that loops through all fields in the BankAccounts form to ensure they're saved as draft data.
By looping through all fields and not hard-coding any of their names we can ensure future modifications catch any draft data not being properly saved to these fields.

What alternative solutions did you explore? (Optional)

I tried saving manually by directly using FormActions.setDraftValues but I think it's better to go for the root cause of the problem, which seems to be fetchCorpayFields in this case.

@Christinadobrzyn
Copy link
Contributor

Hi @allgandalf, can you review this proposal when you have a moment? TY!

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@huult
Copy link
Contributor

huult commented Jan 7, 2025

Maybe the flow has changed? I can’t open the add account option this way.

Screen.Recording.2025-01-07.at.15.01.32.mov

Copy link

melvin-bot bot commented Jan 7, 2025

@Gonals, @Christinadobrzyn, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Christinadobrzyn
Copy link
Contributor

I'm also not able to reproduce this, I'm getting the same prompt where I need to go through Plaid instead of just manually entering bank details.

@Gonals do you know if this is the new workflow and this should be closed?

#54740 (comment)

@Gonals
Copy link
Contributor

Gonals commented Jan 8, 2025

I'm also not able to reproduce this, I'm getting the same prompt where I need to go through Plaid instead of just manually entering bank details.

@Gonals do you know if this is the new workflow and this should be closed?

#54740 (comment)

I'm actually not sure, but maybe it depends on your location?

@LorenzoBloedow
Copy link

Apparently it was reverted, I was working on v9.0.80-2 when I made that proposal. See #54729

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Jan 8, 2025

Ah okay, then I think we can just close this since it's reverted, right? @Gonals @allgandalf does that sounds good?

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2025
@allgandalf
Copy link
Contributor

yes please

Copy link

melvin-bot bot commented Jan 10, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@Christinadobrzyn
Copy link
Contributor

Closing based on - #54740 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

7 participants