Implemented International Bank Account flow #54798

shubham1206agra · 2025-01-04T07:44:46Z

Explanation of Change

Fixed Issues

$ #51082
$ #54743

Tests

https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit#heading=h.nhtsmauf72jq

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-25.at.5.24.19.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-25.at.4.46.43.PM.mov

iOS: Native

Screen.Recording.2024-11-25.at.5.08.17.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-25.at.4.29.32.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-25.at.4.23.43.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-25.at.4.59.34.PM.mov

…low""

melvin-bot · 2025-01-04T07:44:51Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

shubham1206agra · 2025-01-04T16:17:45Z

…f star icon

melvin-bot · 2025-01-04T18:11:15Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2025-01-04T18:11:36Z

@allroundexperts Please ignore this PR.

shubham1206agra · 2025-01-04T18:12:53Z

@DylanDylann Please follow the test doc this time as QA will send us bugs that should not be sent.

shubham1206agra · 2025-01-21T15:47:09Z

@MonilBhavsar Conflicts fixed

MonilBhavsar · 2025-01-21T16:03:12Z

Looks like a bug -

The account has been added successfully page is not appearing now. It used to appear previously

Screen.Recording.2025-01-21.at.11.02.06.AM.mov

MonilBhavsar · 2025-01-21T16:29:40Z

#54798 (comment) (BE Bug, need an eye from @MonilBhavsar)
I will test it today and fix it, if required

I have created an issue for this bug/feature
https://github.com/Expensify/Expensify/issues/463152

MonilBhavsar · 2025-01-21T19:33:32Z

Retested and could not reproduce this #54798 (comment)

src/languages/en.ts

MonilBhavsar · 2025-01-22T16:00:27Z

There are conflicts to resolve. Otherwise, we're good to proceed

MonilBhavsar

Thanks! Let's ship it 🚀

OSBotify · 2025-01-22T16:30:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:27:26Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mvtglobally · 2025-01-23T19:16:57Z

@shubham1206agra @MonilBhavsar @DylanDylann We are not able to open the sheet. Can you pls update the QA steps

shubham1206agra · 2025-01-23T19:18:28Z

@mvtglobally Earlier you were able to open the sheet. Is there a problem now?

MonilBhavsar · 2025-01-23T19:21:34Z

@mvtglobally you should be able to open now, please check
https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit?usp=sharing

mvtglobally · 2025-01-23T19:21:52Z

i am able to open now

francoisl · 2025-01-23T22:00:00Z

src/pages/AddPersonalBankAccountPage.tsx

@@ -112,7 +115,7 @@ function AddPersonalBankAccountPage() {
                                text={translate('walletPage.chooseAccountBody')}
                                plaidData={plaidData}
                                isDisplayedInWalletFlow
-                                onExitPlaid={goBack}
+                                onExitPlaid={canUseInternationalBankAccount ? Navigation.goBack : goBack}


Any idea if this could have caused this blocker? #55672

I tried to revert just this line locally and it didn't fix the issue I linked to, I'll look for something else

dangrous · 2025-01-24T15:33:38Z

This by default caused #55726, right? since we weren't able to add international bank accounts before?

IuliiaHerets · 2025-01-27T11:18:41Z

This PR is failing because of issue #55772

shubham1206agra · 2025-01-27T11:24:18Z

@IuliiaHerets This issue only implements flow in ND. It is not related to OD flows.

IuliiaHerets · 2025-01-27T12:50:14Z

This PR is failing because of issue #55772

github-actions · 2025-01-28T01:50:50Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Revert "[CP Staging] Revert "Implemented International Bank Account f…

4bf95b9

…low""

shubham1206agra and others added 10 commits January 4, 2025 13:15

Merge branch 'Expensify:main' into intl-bank-account

085aeda

Fix navigation from plaid account

6f0a577

Fix navigation from plaid account success setup

e4225f4

Fix navigation from plaid header back button

a060234

Fix button on account type step

6b982b3

Fix scrolling of country page

0a8574f

Fix scrolling of country page

da88626

Fix excluded currency and countries

c07ec58

Fix validation

3cddf30

Fix: Currency does not auto update after changing country

ca22f9b

shubham1206agra added 9 commits January 4, 2025 21:55

Fix: Make default payment method option uses a message icon instead o…

13a8197

…f star icon

Fix the top of the confirmation page header

976956e

Minor fix

dbd5145

Fix draft saving mechanism

d88fe50

Fix testValidation function

1dfe4ca

Fix draft saving on account type step

300a666

Fix offline view of confirmation step

47eb2b4

Fix order of menu items

d9e53a9

Minor fix

4e324cb

shubham1206agra marked this pull request as ready for review January 4, 2025 18:11

shubham1206agra requested a review from a team as a code owner January 4, 2025 18:11

melvin-bot bot requested review from allroundexperts and removed request for a team January 4, 2025 18:11

techievivek mentioned this pull request Jan 6, 2025

Wallet - Account number field is not focused #54742

Closed

8 tasks

MonilBhavsar reviewed Jan 21, 2025

View reviewed changes

src/languages/en.ts Show resolved Hide resolved

Merge branch 'main' into intl-bank-account

63fbf3b

MonilBhavsar approved these changes Jan 22, 2025

View reviewed changes

MonilBhavsar merged commit f835dd3 into Expensify:main Jan 22, 2025
16 checks passed

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

lanitochka17 mentioned this pull request Jan 23, 2025

Wallet - Confirm button is not shown on the currency selector page #55678

Closed

8 tasks

francoisl reviewed Jan 23, 2025

View reviewed changes

francoisl mentioned this pull request Jan 23, 2025

Invoices - Bank account setup RHP starts from the beginning after adding a US bank account #55672

Open

8 tasks

lanitochka17 mentioned this pull request Jan 23, 2025

[$250] Wallet - Check Box is unselected when changing Account Type #55688

Open

8 tasks

IuliiaHerets mentioned this pull request Jan 27, 2025

Wallet - Unable to add non-US account in OD with Private Domains #55772

Closed

8 tasks

IuliiaHerets mentioned this pull request Jan 27, 2025

Wallet - Country selector is not shown for public domain emails #55778

Closed

8 tasks

This was referenced Jan 28, 2025

[HOLD for payment 2025-02-04] Feature - Allow user to create international bank account #51082

Open

[HOLD for payment 2025-02-04] [Tracking Issue] Fixes to Implemented International Bank Account flow #54743

Closed

shubham1206agra deleted the intl-bank-account branch February 3, 2025 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented International Bank Account flow #54798

Implemented International Bank Account flow #54798

shubham1206agra commented Jan 4, 2025

melvin-bot bot commented Jan 4, 2025

shubham1206agra commented Jan 4, 2025 •

edited

Loading

melvin-bot bot commented Jan 4, 2025

shubham1206agra commented Jan 4, 2025

shubham1206agra commented Jan 4, 2025

shubham1206agra commented Jan 21, 2025

MonilBhavsar commented Jan 21, 2025

MonilBhavsar commented Jan 21, 2025

MonilBhavsar commented Jan 21, 2025

MonilBhavsar commented Jan 22, 2025

MonilBhavsar left a comment

OSBotify commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

mvtglobally commented Jan 23, 2025

shubham1206agra commented Jan 23, 2025

MonilBhavsar commented Jan 23, 2025 •

edited

Loading

mvtglobally commented Jan 23, 2025

francoisl Jan 23, 2025

MonilBhavsar Jan 23, 2025

francoisl Jan 23, 2025

dangrous commented Jan 24, 2025

IuliiaHerets commented Jan 27, 2025

shubham1206agra commented Jan 27, 2025

IuliiaHerets commented Jan 27, 2025

github-actions bot commented Jan 28, 2025

Implemented International Bank Account flow #54798

Implemented International Bank Account flow #54798

Conversation

shubham1206agra commented Jan 4, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 4, 2025

shubham1206agra commented Jan 4, 2025 • edited Loading

melvin-bot bot commented Jan 4, 2025

shubham1206agra commented Jan 4, 2025

shubham1206agra commented Jan 4, 2025

shubham1206agra commented Jan 21, 2025

MonilBhavsar commented Jan 21, 2025

MonilBhavsar commented Jan 21, 2025

MonilBhavsar commented Jan 21, 2025

MonilBhavsar commented Jan 22, 2025

MonilBhavsar left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 22, 2025

github-actions bot commented Jan 23, 2025

mvtglobally commented Jan 23, 2025

shubham1206agra commented Jan 23, 2025

MonilBhavsar commented Jan 23, 2025 • edited Loading

mvtglobally commented Jan 23, 2025

francoisl Jan 23, 2025

Choose a reason for hiding this comment

MonilBhavsar Jan 23, 2025

Choose a reason for hiding this comment

francoisl Jan 23, 2025

Choose a reason for hiding this comment

dangrous commented Jan 24, 2025

IuliiaHerets commented Jan 27, 2025

shubham1206agra commented Jan 27, 2025

IuliiaHerets commented Jan 27, 2025

github-actions bot commented Jan 28, 2025

shubham1206agra commented Jan 4, 2025 •

edited

Loading

MonilBhavsar commented Jan 23, 2025 •

edited

Loading