-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented International Bank Account flow #52322
Implemented International Bank Account flow #52322
Conversation
@@ -1,6 +1,6 @@ | |||
type VerifyIdentityForBankAccountParams = { | |||
bankAccountID: number; | |||
onfidoData: string; | |||
policyID?: string; | |||
policyID: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB, We could probably revert this change as the code works with empty policyID
@shubham1206agra @MonilBhavsar What our QA team should be validating here? Could you help with this? |
@kavimuru the QA steps are in this doc https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit?usp=sharing |
Please tag me and @shubham1206agra if any regression is coming out from this PR. We'll handle that in a followup PR. Thanks! |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.80-1 🚀
|
reverted - see #54729 |
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.80-6 🚀
|
Explanation of Change
Fixed Issues
$ #51082
Tests
https://docs.google.com/document/d/19ltca0iKwB00pReokjBf9rEHoi1u8y-2_x-82jMibho/edit?pli=1&tab=t.0#bookmark=id.tf0af0lugbin
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-25.at.5.24.19.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-11-25.at.4.46.43.PM.mov
iOS: Native
Screen.Recording.2024-11-25.at.5.08.17.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-11-25.at.4.29.32.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-11-25.at.4.23.43.PM.mov
MacOS: Desktop
Screen.Recording.2024-11-25.at.4.59.34.PM.mov