[HOLD for payment 2025-01-13] [HOLD for payment 2025-01-07] [$250] Web- Search- Two filter tooltips are shown when navigating to Reports page for the second time

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Go to Reports and quickly go back to Inbox before Filter tooltip is shown.
4. Go to Reports again.

Expected Result:

Only one Filter tooltip is shown.

Actual Result:

Two Filter tooltips are shown. The second one is at the top left.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702706_1735256120432.20241227_073045.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021872595838175147651
• Upwork Job ID: 1872595838175147651
• Last Price Increase: 2024-12-27

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

Looks related to this issue which was deemed NAB: #54596

[Beamanator]

This tooltip in the Search page header was just added back in #54263

cc @ishpaul777 @rayane-djouah @puneetlath

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021872595838175147651

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[Beamanator]

Marking external to hopefully get some movement, but this def comes from the above linked PR. Also I'm OOO early today so probably won't be able to push this all the way through

[linhvovan29546]

Edited by proposal-police: This proposal was edited at 2024-12-27 13:27:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web- Search- Two filter tooltips are shown when navigating to Reports page for the second time

What is the root cause of that problem?

The issue arises from the useProductTrainingContext hook, which manages the tooltip display. The shouldShowProductTrainingTooltip flag remains true when navigating to inbox page

App/src/components/Search/SearchPageHeader.tsx

Lines 62 to 65 in e94df0f

	const {renderProductTrainingTooltip, shouldShowProductTrainingTooltip, hideProductTrainingTooltip} = useProductTrainingContext(
	CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SEARCH_FILTER_BUTTON_TOOLTIP,
	isFocused,
	);

When navigating to the inbox page, the shouldShowProductTrainingTooltip flag remains true. And here, the logic to show the tooltip is wrapped inside a timeout, causing the tooltip to be triggered and displayed

App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx

Lines 71 to 81 in e94df0f

	const timerID = setTimeout(() => {
	removePendingTooltipRef.current();
	show.current?.();
	didShow.current = true;
	removeActiveTooltipRef.current = TooltipManager.addActiveTooltip(closeTooltip);
	}, 500);
	removePendingTooltipRef.current = TooltipManager.addPendingTooltip(timerID);
	return () => {
	removePendingTooltipRef.current();
	clearTimeout(timerID);
	};

Debug

Code	Log

### What changes do you think we should make to solve the problem? We can update the `useProductTrainingContext` hook to check `shouldShow` inside `shouldShowProductTrainingTooltip` function, to make sure the tooltip only display if shouldShow true

App/src/components/ProductTrainingContext/index.tsx

Lines 207 to 209 in e94df0f

	const shouldShowProductTrainingTooltip = useMemo(() => {
	return shouldRenderTooltip(tooltipName);
	}, [shouldRenderTooltip, tooltipName]);

const shouldShowProductTrainingTooltip = useMemo(() => {
       return shouldShow && shouldRenderTooltip(tooltipName);
   }, [shouldRenderTooltip, tooltipName, shouldShow]);

POC

Before	After
Screen.Recording.2024-12-27.at.8.18.04.PM.mov	Screen.Recording.2024-12-27.at.7.55.58.PM.mov

### What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future? N/A

What alternative solutions did you explore? (Optional)

N/A

[jjcoffee]

@linhvovan29546's proposal makes sense to me, but I think we should give @ishpaul777 and @rayane-djouah a chance to work on this since it's a regression from #54263.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @Beamanator is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[izarutskaya]

Still reproducible

Build v9.0.79-2

Recording.2946.mp4

[ishpaul777]

i tried multiple times i could not reproduce anymore @izarutskaya

@rayane-djouah can you please test this again ?

Screen.Recording.2024-12-28.at.10.38.18.PM.mov

[Beamanator]

Hmm yeah i also couldn't reproduce on staging! So I'll call this NAB for now, but won't close it yet

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [fix] Web- Search- Two filter tooltips are shown when navigating to Reports page for the second time #54627

If no regressions arise, payment will be issued on 2025-01-07. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment through NewDot Manual Requests

[melvin-bot]

@jjcoffee @sakluger @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jjcoffee]

No payment due for me (or anyone I guess since this was a regression) as I wasn't involved in the PR.

[puneetlath]

Yeah I think we can just close this one. Reopen if you disagree.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [fix] Web- Search- Two filter tooltips are shown when navigating to Reports page for the second time #54627

If no regressions arise, payment will be issued on 2025-01-13. 🎊

[melvin-bot]

@Beamanator @sakluger @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]