-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2025-01-07] Create ProductTrainingContext and Clean existing tooltips to use a hook #53086
Comments
@puneetlath 👋 Please assign me here |
In progress will be ready for review today 🤞 |
@puneetlath, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@puneetlath Please assign me here |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.76-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-25. 🎊 For reference, here are some details about the assignees on this issue:
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
It looks like the latest re-merge of the PR caused #54600 - can y'all find a quick fix? 🙏 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
FIx has been CPed |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-07. 🎊 For reference, here are some details about the assignees on this issue:
|
Manual tests will be added as part of the project wrap-up: Doc section |
Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
Payment Summary
BugZero Checklist (@twisterdotcom)
|
Okay, for this specifically, we are paying out and how much? $250? for some reverts? |
@twisterdotcom I will pay them for the project as a whole rather than for this issue individually. |
Nice, can we close this one now? |
Yep, we can close. |
Part of the Migrate Existing Users to NewDot project
Main issue: https://github.com/Expensify/Expensify/issues/437980
Doc section: https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.mvu5k3qn2ftd
Project:
Feature Description
Create ProductTrainingContext and Clean existing tooltips to use a hook
useProductTrainingContext
instead of individually rendering tooltips in their respective components.Existing tooltips in product right now:
Detailed Implementation https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.vt3o5zhw550v
Issue Owner
Current Issue Owner: @ishpaul777The text was updated successfully, but these errors were encountered: