Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-07] Create ProductTrainingContext and Clean existing tooltips to use a hook #53086

Closed
ishpaul777 opened this issue Nov 25, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@ishpaul777
Copy link
Contributor

ishpaul777 commented Nov 25, 2024

Part of the Migrate Existing Users to NewDot project

Main issue: https://github.com/Expensify/Expensify/issues/437980
Doc section: https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.mvu5k3qn2ftd
Project:

Feature Description

Create ProductTrainingContext and Clean existing tooltips to use a hook useProductTrainingContext instead of individually rendering tooltips in their respective components.

Existing tooltips in product right now:

  1. Get started tooltip on concirge chat LHN
  2. Rename Saved Search
  3. QuickAction Button: Global Create
  4. Workspace chat - Create "+"

Detailed Implementation https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.vt3o5zhw550v

Issue OwnerCurrent Issue Owner: @ishpaul777
@ishpaul777
Copy link
Contributor Author

@puneetlath 👋 Please assign me here

@ishpaul777
Copy link
Contributor Author

In progress will be ready for review today 🤞

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

@puneetlath, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Dec 9, 2024
@rayane-d
Copy link
Contributor

@puneetlath Please assign me here

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 17, 2024
@melvin-bot melvin-bot bot changed the title Create ProductTrainingContext and Clean existing tooltips to use a hook [HOLD for payment 2024-12-25] Create ProductTrainingContext and Clean existing tooltips to use a hook Dec 18, 2024
Copy link

melvin-bot bot commented Dec 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 18, 2024
Copy link

melvin-bot bot commented Dec 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.76-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-25. 🎊

For reference, here are some details about the assignees on this issue:

@puneetlath puneetlath changed the title [HOLD for payment 2024-12-25] Create ProductTrainingContext and Clean existing tooltips to use a hook Create ProductTrainingContext and Clean existing tooltips to use a hook Dec 19, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 25, 2024
Copy link

melvin-bot bot commented Dec 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added the Overdue label Dec 27, 2024
@Beamanator
Copy link
Contributor

Beamanator commented Dec 27, 2024

It looks like the latest re-merge of the PR caused #54600 - can y'all find a quick fix? 🙏

Copy link

melvin-bot bot commented Dec 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@ishpaul777
Copy link
Contributor Author

It looks like the latest re-merge of the PR caused #54600 - can y'all find a quick fix? 🙏

FIx has been CPed

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Dec 28, 2024
@melvin-bot melvin-bot bot changed the title Create ProductTrainingContext and Clean existing tooltips to use a hook [HOLD for payment 2025-01-07] Create ProductTrainingContext and Clean existing tooltips to use a hook Dec 31, 2024
Copy link

melvin-bot bot commented Dec 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-07. 🎊

For reference, here are some details about the assignees on this issue:

@rayane-d
Copy link
Contributor

rayane-d commented Jan 1, 2025

Manual tests will be added as part of the project wrap-up: Doc section

Copy link

melvin-bot bot commented Jan 7, 2025

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Jan 7, 2025

Payment Summary

Upwork Job

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@twisterdotcom
Copy link
Contributor

Okay, for this specifically, we are paying out and how much? $250? for some reverts?

@puneetlath
Copy link
Contributor

@twisterdotcom I will pay them for the project as a whole rather than for this issue individually.

@twisterdotcom
Copy link
Contributor

Nice, can we close this one now?

@puneetlath
Copy link
Contributor

Yep, we can close.

@github-project-automation github-project-automation bot moved this from First Cohort - CRITICAL to Done in [#whatsnext] #migrate Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
Development

No branches or pull requests

6 participants