[HOLD for payment 2025-01-30] [$250] Web - Reports - Filters button tooltip is not displayed properly

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Click on the search icon on the top right (do not go to Reports).
4. Enter anything and search.

Expected Result:

Tooltip will be properly displayed under Filters button.

Actual Result:

Tooltip is incorrectly displayed.
The arrow is under Filters button, but the content (the box) is far away from the arrow.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702688_1735252108451.2tip.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021872571944019699277
• Upwork Job ID: 1872571944019699277
• Last Price Increase: 2024-12-27

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mitarachim]

not reproducible when disable Use Staging Server

bandicam.2024-12-27.06-35-39-785.mp4

[linhvovan29546]

Edited by proposal-police: This proposal was edited at 2024-12-27 09:30:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Reports - Filters button tooltip is not displayed properly

What is the root cause of that problem?

The tooltip displayed here

App/src/components/Search/SearchPageHeader.tsx

Lines 359 to 369 in e94df0f

	<EducationalTooltip
	shouldRender={shouldShowProductTrainingTooltip}
	anchorAlignment={{
	vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
	horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
	}}
	shouldUseOverlay
	shiftHorizontal={variables.searchFiltersTooltipShiftHorizontal}
	wrapperStyle={styles.productTrainingTooltipWrapper}
	renderTooltipContent={renderProductTrainingTooltip}
	onHideTooltip={hideProductTrainingTooltip}

And on the web and desktop we renter tooltip with shiftHorizontal=variables.searchFiltersTooltipShiftHorizontalNarrow(-20) which causes the tooltip's position to be incorrect.

What changes do you think we should make in order to solve the problem?

To resolve this issue, we can:

• Update shiftHorizontal to 0.
• Set anchorAlignment.horizontal to CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.CENTER, similar to how it is handled in SearchTypeMenuNarrow.
  NOTE: In the SearchPageHeader component, In the SearchPageHeader component, since the children inside SearchPageHeaderInput are rendered conditionally based on isCannedQuery, we also need to ensure that isCannedQuery is checked appropriately

 <EducationalTooltip
                        shouldRender={shouldShowProductTrainingTooltip}
                        anchorAlignment={{
                            vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
                            horizontal: isWebOrDesktop && !isCannedQuery ? CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.CENTER : CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
                        }}
                        shouldUseOverlay
                        shiftHorizontal={isWebOrDesktop && !isCannedQuery ? 0 : variables.searchFiltersTooltipShiftHorizontal}
                        wrapperStyle={styles.productTrainingTooltipWrapper}
                        renderTooltipContent={renderProductTrainingTooltip}
                        onHideTooltip={hideProductTrainingTooltip}
                    >

POC

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[techievivek]

Not a blocker, sending it to external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021872571944019699277

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[linhvovan29546]

Updated proposal #54596 (comment)
We need to ensure that isCannedQuery is checked as well.

[techievivek]

@thesahindia Can you please review the proposals here? Thanks.

[thesahindia]

@daledah's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Filters button tooltip is not displayed properly #54677

If no regressions arise, payment will be issued on 2025-01-30. 🎊

For reference, here are some details about the assignees on this issue:

• @thesahindia requires payment through NewDot Manual Requests
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot]

@thesahindia @bfitzexpensify @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @thesahindia owed $250 via NewDot
• ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1872571944019699277/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[bfitzexpensify]

Offer sent for payment @daledah

@thesahindia, please complete the BZ checklist

[melvin-bot]

@techievivek, @bfitzexpensify, @thesahindia, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@techievivek, @bfitzexpensify, @thesahindia, @daledah Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@techievivek, @bfitzexpensify, @thesahindia, @daledah 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[thesahindia]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Can't find a specific PR responsible for it.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Log in with a new account
2. Click on the search icon on the top right (do not go to reports)
3. Enter anything and search
4. Verify that the tooltip is properly displayed under filters button

Do we agree 👍 or 👎