Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix peer dependency resolution error #6611

Merged
merged 3 commits into from
Mar 18, 2023

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

Updates dependencies that required --legacy-peer-deps for initial installs.

@jcfranco jcfranco requested review from alisonailea and benelan March 17, 2023 19:38
@jcfranco jcfranco requested a review from a team as a code owner March 17, 2023 19:38
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Mar 17, 2023
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 17, 2023
This was added because the npx command was throwing an error due to
installing the caniuse package without the --legacy-peer-deps flag.
:
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! As discussed on Teams, I removed a workaround that is no longer necessary and pushed it to this branch. Otherwise it LGTM!

@jcfranco jcfranco merged commit cbf3f5a into master Mar 18, 2023
@jcfranco jcfranco deleted the jcfranco/fix-peer-dependency-resolution-error branch March 18, 2023 05:12
jcfranco added a commit that referenced this pull request Mar 21, 2023
**Related Issue:** N/A

## Summary

Fixes `@stencil-community/strict-mutable` errors showing up after
landing #6611.

**Note**: props mutated by some of our utils need to be ignored as
`@stencil-community/eslint-plugin` doesn't check for this.
benelan added a commit that referenced this pull request Mar 27, 2023
…ocus-revert

* origin/master: (30 commits)
  fix(modal): prevent error when calling setFocus on a recently rendered and opened modal (`dist-custom-elements`) (#6666)
  fix(tile-select): fix click not firing in custom-elements build (#6665)
  fix(card): provide more meaningful screen reader label for selectable cards (deprecates `deselect` message override) (#6657)
  fix(pagination): add current page information for screen readers (#6637)
  chore: update jsbin sample to CC 1.0 breaking changes and latest jsapi version (#6651)
  feat(text-area): add calcite-text-area component (#5644)
  chore(release): 1.1.1-next.2
  fix(tile): adds styling to `tile` where `link` is present for additional distinction (#6628)
  docs(input, input-number, input-text): api consistency across components (#6634)
  docs(accordion-item): add actions-start and actions-end slots (#6631)
  docs(modal): kebab-case slot names and sticky context (#6625)
  chore(release): 1.1.1-next.1
  fix: restore form control validation in Safari (#6623)
  chore(linting): fix linting errors (#6613)
  build(deps): Bump eslint-plugin-react from 7.31.11 to 7.32.2 (#6619)
  build(deps): Bump eslint from 8.35.0 to 8.36.0 (#6620)
  build(deps): Bump @types/lodash-es from 4.17.6 to 4.17.7 (#6621)
  build: fix peer dependency resolution error (#6611)
  ci: update user-defined priority (#6609)
  build: update browserslist db (#6527)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants