Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix peer dependency resolution error #6611

Merged
merged 3 commits into from
Mar 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
},
"extends": [
"plugin:@esri/calcite-components/recommended",
"plugin:@stencil/recommended",
"plugin:@stencil-community/recommended",
"plugin:@typescript-eslint/recommended",
"plugin:jest/recommended",
"plugin:jsdoc/recommended",
Expand Down Expand Up @@ -38,14 +38,14 @@
"message": "Use keydown instead for consistent interaction behavior (e.g., closing, moving focus, etc.)."
}
],
"@stencil/decorators-context": "off",
"@stencil/decorators-style": "warn",
"@stencil/no-unused-watch": "off",
"@stencil/own-methods-must-be-private": "off",
"@stencil/own-props-must-be-private": "off",
"@stencil/prefer-vdom-listener": "warn",
"@stencil/required-jsdoc": "off",
"@stencil/strict-boolean-conditions": "off",
"@stencil-community/decorators-context": "off",
"@stencil-community/decorators-style": "warn",
"@stencil-community/no-unused-watch": "off",
"@stencil-community/own-methods-must-be-private": "off",
"@stencil-community/own-props-must-be-private": "off",
"@stencil-community/prefer-vdom-listener": "warn",
"@stencil-community/required-jsdoc": "off",
"@stencil-community/strict-boolean-conditions": "off",
"@typescript-eslint/ban-types": "warn",
"@typescript-eslint/explicit-module-boundary-types": [
"error",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version-file: package.json
- run: npm install --legacy-peer-deps
- run: npm install
- if: steps.markdown-check.outputs.SKIP == 'false'
name: Publish to Chromatic
uses: chromaui/action@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-next.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: e2e test
run: |
npm ci --legacy-peer-deps
npm ci
npm test
- name: storybook/next deployment
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version-file: package.json
- run: npm ci --legacy-peer-deps
- run: npm ci
- if: steps.markdown-check.outputs.SKIP == 'false'
run: npm test
2 changes: 0 additions & 2 deletions .github/workflows/update-browserslist-db.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ jobs:
run: |
git config --global user.email "github-actions[bot]@users.noreply.github.com"
git config --global user.name "github-actions[bot]"
npm install --save-dev caniuse-lite --legacy-peer-deps
npx update-browserslist-db@latest
npm uninstall --legacy-peer-deps caniuse-lite
- name: create pull request
uses: peter-evans/create-pull-request@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
node-version-file: package.json
- name: generate doc
run: |
npm ci --legacy-peer-deps
npm ci
npx stencil build --docs
npm run lint:md
- name: commit readme files/create pull request
Expand Down
10 changes: 0 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,16 +116,6 @@ cd calcite-components
npm install
```

> **NOTE**
>
> The first time installing dependencies, you may need to use the `legacy-peer-deps` flag due to an Stencil/ESLint dependency conflict:
>
> ```sh
> npm install --legacy-peer-deps
> ```
>
> Hopefully this will no longer be an issue once [`@stencil/eslint-plugin`](https://github.com/ionic-team/stencil-eslint) supports ESLint v8.

Next, start the local Stencil development server on localhost:

```sh
Expand Down
Loading