fix(pagination): add current page information for screen readers #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
|
@geospatialem Do you have any suggestions on how we could automate testing for this? |
Can't think of a way for us to add in an automated test with axe specific to the attribute, other than the general We could potentially add in more attributes to the current test... (sample below). @jcfranco WDYT? <calcite-pagination></calcite-pagination>to <calcite-pagination page-size="10" start-item="50" total-items="100"></calcite-pagination> |
github-actions
bot
added this to the 2023 March Priorities - No breaking changes milestone
benelan
added a commit
that referenced
this pull request
Mar 27, 2023
…ocus-revert * origin/master: (30 commits) fix(modal): prevent error when calling setFocus on a recently rendered and opened modal (`dist-custom-elements`) (#6666) fix(tile-select): fix click not firing in custom-elements build (#6665) fix(card): provide more meaningful screen reader label for selectable cards (deprecates `deselect` message override) (#6657) fix(pagination): add current page information for screen readers (#6637) chore: update jsbin sample to CC 1.0 breaking changes and latest jsapi version (#6651) feat(text-area): add calcite-text-area component (#5644) chore(release): 1.1.1-next.2 fix(tile): adds styling to `tile` where `link` is present for additional distinction (#6628) docs(input, input-number, input-text): api consistency across components (#6634) docs(accordion-item): add actions-start and actions-end slots (#6631) docs(modal): kebab-case slot names and sticky context (#6625) chore(release): 1.1.1-next.1 fix: restore form control validation in Safari (#6623) chore(linting): fix linting errors (#6613) build(deps): Bump eslint-plugin-react from 7.31.11 to 7.32.2 (#6619) build(deps): Bump eslint from 8.35.0 to 8.36.0 (#6620) build(deps): Bump @types/lodash-es from 4.17.6 to 4.17.7 (#6621) build: fix peer dependency resolution error (#6611) ci: update user-defined priority (#6609) build: update browserslist db (#6527) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5590
Summary
Add
aria-currentto provide state information.